Re: [PATCH v4 1/4] gcc-plugins: Add the initify gcc plugin

From	"PaX Team" <pageexec@freemail.hu>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/4] gcc-plugins: Add the initify gcc plugin
Date	2016-12-17 00:20 +0100
Message-ID	<sP9Xd-1Cb-53@gated-at.bofh.it> (permalink)
References	<sP9u9-1bb-9@gated-at.bofh.it> <sP9Xd-1Cb-55@gated-at.bofh.it> <sP9Nv-1xq-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 16 Dec 2016 at 15:02, Kees Cook wrote:

> >>  static inline struct cgraph_node_hook_list *cgraph_add_function_insertion_hook(cgraph_node_hook hook, void *data)
> >>  {
> >>   return symtab->add_cgraph_insertion_hook(hook, data);
> >
> > ...this one aren't needed by any plugins upstream so maybe introduce them when
> > the needed arises?
> 
> Hrm, sure. I was just going off of Emese's v3. (And this is partially
> an artifact of basing off of v4.9-rc2... I'll refresh it to v4.10-rc2
> once it's out.)
> 
> > and the whole patch against gcc-common.h would also conflict
> > with the version i maintain and that you said you'd sync to so there's a decision
> > to be made regarding how this will is to be maintained...
> 
> What's easiest for you? I'm okay to carry "unused by upstream yet"
> functions and macros in gcc-common, though I don't like carrying lots
> of commented out stuff. :P

well, as i explained it the other day, my version has 'everything but the
kitchen sink' because i use it for development which isn't necessarily what
other projects need or want for themselves (e.g., consider the consequences
of Arnd's recent call to reduce the number of supported gcc versions, if that
goes anywhere above 4.5, gcc-common.h in linux can be further trimmed from my
version). at the end of the day this is a policy call and i'm not the one to
make it for linux ;).

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 1/4] gcc-plugins: Add the initify gcc plugin "PaX Team" <pageexec@freemail.hu> - 2016-12-16 23:50 +0100
  Re: [PATCH v4 1/4] gcc-plugins: Add the initify gcc plugin Kees Cook <keescook@chromium.org> - 2016-12-17 00:10 +0100
    Re: [PATCH v4 1/4] gcc-plugins: Add the initify gcc plugin "PaX Team" <pageexec@freemail.hu> - 2016-12-17 00:20 +0100

csiph-web