Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1543789

Re: [PATCH v3 11/15] livepatch: use kstrtobool() in enabled_store()

Show all headers | View raw

On Fri, Dec 16, 2016 at 05:55:55PM +0100, Petr Mladek wrote:
> On Thu 2016-12-08 12:08:36, Josh Poimboeuf wrote:
> > The sysfs enabled value is a boolean, so kstrtobool() is a better fit
> > for parsing the input string since it does the range checking for us.
> > 
> > Suggested-by: Petr Mladek <pmladek@suse.com>
> > Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> > ---
> >  kernel/livepatch/core.c | 11 ++++-------
> >  1 file changed, 4 insertions(+), 7 deletions(-)
> > 
> > diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
> > index 6a137e1..8ca8a0e 100644
> > --- a/kernel/livepatch/core.c
> > +++ b/kernel/livepatch/core.c
> > @@ -408,26 +408,23 @@ static ssize_t enabled_store(struct kobject *kobj, struct kobj_attribute *attr,
> >  {
> >  	struct klp_patch *patch;
> >  	int ret;
> > -	unsigned long val;
> > +	bool enabled;
> >  
> > -	ret = kstrtoul(buf, 10, &val);
> > +	ret = kstrtobool(buf, &enabled);
> >  	if (ret)
> >  		return -EINVAL;
> 
> I would return "ret" here. It is -EINVAL as well but... ;-)

That was a preexisting issue with the kstrtoul() return code, but I'll
sneak your suggested change into this patch if nobody objects.

> Anyway, feel free to use:
> 
> Reviewed-by: Petr Mladek <pmladek@suse.com>
> 
> Best Regards,
> Petr

-- 
Josh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 11/15] livepatch: use kstrtobool() in enabled_store() Petr Mladek <pmladek@suse.com> - 2016-12-16 18:00 +0100
  Re: [PATCH v3 11/15] livepatch: use kstrtobool() in enabled_store() Josh Poimboeuf <jpoimboe@redhat.com> - 2016-12-16 23:20 +0100
    Re: [PATCH v3 11/15] livepatch: use kstrtobool() in  enabled_store() Miroslav Benes <mbenes@suse.cz> - 2016-12-23 14:20 +0100

csiph-web