Re: [TSN RFC v2 0/9] TSN driver for the kernel

From	Richard Cochran <richardcochran@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [TSN RFC v2 0/9] TSN driver for the kernel
Date	2016-12-16 23:10 +0100
Message-ID	<sP8Rs-Yj-19@gated-at.bofh.it> (permalink)
References	<sP57b-75S-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Dec 16, 2016 at 06:59:04PM +0100, henrik@austad.us wrote:
> The driver is directed via ConfigFS as we need userspace to handle
> stream-reservation (MSRP), discovery and enumeration (IEEE 1722.1) and
> whatever other management is needed.

I complained about configfs before, but you didn't listen.

> 2 new fields in netdev_ops have been introduced, and the Intel
> igb-driver has been updated (as this an AVB-capable NIC which is
> available as a PCI-e card).

The igb hacks show that you are on the wrong track.  We can and should
be able to support TSN without resorting to driver specific hacks and
module parameters.

> Before reading on - this is not even beta, but I'd really appreciate if
> people would comment on the overall architecture and perhaps provide
> some pointers to where I should improve/fix/update

As I said before about V1, this architecture stinks.  You appear to
have continued hacking along and posted the same design again.  Did
you even address any of the points I raised back then?

You are trying to put tons of code into the kernel that really belongs
in user space, and at the same time, you omit critical functions that
only the kernel can provide.

> There are at least one AVB-driver (the AV-part of TSN) in the kernel
> already.

And which driver is that?

Thanks,
Richard

Thread

[TSN RFC v2 0/9] TSN driver for the kernel henrik@austad.us - 2016-12-16 19:10 +0100
  [TSN RFC v2 4/9] Adding TSN-driver to Intel I210 controller henrik@austad.us - 2016-12-16 19:10 +0100
  [TSN RFC v2 1/9] igb: add missing fields to TXDCTL-register henrik@austad.us - 2016-12-16 19:10 +0100
  [TSN RFC v2 8/9] AVB ALSA - Add ALSA shim for TSN henrik@austad.us - 2016-12-16 19:10 +0100
  [TSN RFC v2 5/9] Add TSN header for the driver henrik@austad.us - 2016-12-16 19:10 +0100
    Re: [TSN RFC v2 5/9] Add TSN header for the driver Richard Cochran <richardcochran@gmail.com> - 2016-12-16 23:20 +0100
      Re: [TSN RFC v2 5/9] Add TSN header for the driver Henrik Austad <henrik@austad.us> - 2016-12-17 10:00 +0100
  Re: [TSN RFC v2 0/9] TSN driver for the kernel Greg <gvrose8192@gmail.com> - 2016-12-16 19:20 +0100
    Re: [TSN RFC v2 0/9] TSN driver for the kernel David Miller <davem@davemloft.net> - 2016-12-16 19:30 +0100
      Re: [TSN RFC v2 0/9] TSN driver for the kernel Henrik Austad <henrik@austad.us> - 2016-12-16 20:10 +0100
  Re: [TSN RFC v2 0/9] TSN driver for the kernel Richard Cochran <richardcochran@gmail.com> - 2016-12-16 23:10 +0100
    Re: [TSN RFC v2 0/9] TSN driver for the kernel Henrik Austad <henrik@austad.us> - 2016-12-17 10:10 +0100
      Re: [TSN RFC v2 0/9] TSN driver for the kernel Richard Cochran <richardcochran@gmail.com> - 2016-12-17 21:10 +0100

csiph-web