Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1543734

[PATCH] staging: comedi: ni_670x: using the BIT(x) macro

From Saber Rezvani <irsaber@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] staging: comedi: ni_670x: using the BIT(x) macro
Date 2016-12-16 21:30 +0100
Message-ID <sP7iG-8mw-7@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


Fix the checkpatch.pl issue:
CHECK: Prefer using the BIT macro
replacing bit shifting on 1 with the BIT(x) macro.

Signed-off-by: Saber Rezvani <irsaber@gmail.com>
---
 drivers/staging/comedi/drivers/ni_670x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/ni_670x.c b/drivers/staging/comedi/drivers/ni_670x.c
index 74911db..1d3ff60 100644
--- a/drivers/staging/comedi/drivers/ni_670x.c
+++ b/drivers/staging/comedi/drivers/ni_670x.c
@@ -141,7 +141,7 @@ static int ni_670x_dio_insn_config(struct comedi_device *dev,
 
 /* ripped from mite.h and mite_setup2() to avoid mite dependency */
 #define MITE_IODWBSR	0xc0	 /* IO Device Window Base Size Register */
-#define WENAB		(1 << 7) /* window enable */
+#define WENAB		BIT(7) /* window enable */
 
 static int ni_670x_mite_init(struct pci_dev *pcidev)
 {
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH] staging: comedi: ni_670x: using the BIT(x) macro Saber Rezvani <irsaber@gmail.com> - 2016-12-16 21:30 +0100
  Re: [PATCH] staging: comedi: ni_670x: using the BIT(x) macro Ian Abbott <abbotti@mev.co.uk> - 2016-12-19 18:50 +0100

csiph-web