Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1543696

Re: [PATCH 1/1] tools: net: bpf_dbg.c fixed keyboard typo

From Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/1] tools: net: bpf_dbg.c fixed keyboard typo
Date 2016-12-16 20:10 +0100
Message-ID <sP63f-7FI-7@gated-at.bofh.it> (permalink)
References <sP5qy-7cn-11@gated-at.bofh.it>
Organization Cogent Embedded

Show all headers | View raw

Hello.

On 12/16/2016 09:21 PM, Ozgur Karatas wrote:

> This patch fixed to keyboard typo, brackets not closed.
> I think, it should be close to parenthes.
>
> Signed-off-by: Ozgur Karatas <okaratas@member.fsf.org>
> ---
>  tools/net/bpf_dbg.c       | 2 +-
>  1 files changed, 1 insertion(+), 1 deletions(-)
>
> diff --git a/tools/net/bpf_dbg.c b/tools/net/bpf_dbg.c
> index 4f254bc..f715f46 100644
> --- a/tools/net/bpf_dbg.c
> +++ b/tools/net/bpf_dbg.c
> @@ -1213,7 +1213,7 @@ static int cmd_disassemble(char *line_string)
>
>  	if (!bpf_prog_loaded())
>  		return CMD_ERR;
> -	if (strlen(line_string) > 0 &&
> +	if (strlen(line_string) > 0 &&)

    Have tried to you compile that? :-/

>  	    (line = strtoul(line_string, NULL, 10)) < bpf_prog_len)

    I think the code was correct before your patch...

>  		single_line = true;
>  	if (single_line)

MBR, Sergei

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] tools: net: bpf_dbg.c fixed keyboard typo Ozgur Karatas <okaratas@member.fsf.org> - 2016-12-16 19:30 +0100
  Re: [PATCH 1/1] tools: net: bpf_dbg.c fixed keyboard typo Joe Perches <joe@perches.com> - 2016-12-16 19:40 +0100
    Re: [PATCH 1/1] tools: net: bpf_dbg.c fixed keyboard typo Ozgur Karatas <okaratas@member.fsf.org> - 2016-12-16 20:00 +0100
    Re: [PATCH 1/1] tools: net: bpf_dbg.c fixed keyboard typo Ozgur Karatas <okaratas@member.fsf.org> - 2016-12-16 20:00 +0100
  Re: [PATCH 1/1] tools: net: bpf_dbg.c fixed keyboard typo Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-12-16 20:10 +0100
    Re: [PATCH 1/1] tools: net: bpf_dbg.c fixed keyboard typo Ozgur Karatas <okaratas@member.fsf.org> - 2016-12-16 20:20 +0100
  Re: [PATCH 1/1] tools: net: bpf_dbg.c fixed keyboard typo Daniel Borkmann <daniel@iogearbox.net> - 2016-12-16 20:40 +0100

csiph-web