Re: net/3com/3c515: Fix timer handling, prevent leaks and crashes

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: net/3com/3c515: Fix timer handling, prevent leaks and crashes
Date	2016-12-16 19:30 +0100
Message-ID	<sP5qy-7cn-19@gated-at.bofh.it> (permalink)
References	<sNggp-1Wh-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Thomas Gleixner <tglx@linutronix.de>
Date: Sun, 11 Dec 2016 18:31:22 +0100 (CET)

> The timer handling in this driver is broken in several ways:
> 
> - corkscrew_open() initializes and arms a timer before requesting the
>   device interrupt. If the request fails the timer stays armed.
> 
>   A second call to corkscrew_open will unconditionally reinitialize the
>   quued timer and arm it again. Also a immediate device removal will leave
>   the timer queued because close() is not called (open() failed) and
>   therefore nothing issues del_timer().
> 
>   The reinitialization corrupts the link chain in the timer wheel hash
>   bucket and causes a NULL pointer dereference when the timer wheel tries
>   to operate on that hash bucket. Immediate device removal lets the link
>   chain poke into freed and possibly reused memory.
> 
>   Solution: Arm the timer after the successful irq request.
> 
> - corkscrew_close() uses del_timer()
> 
>   On close the timer is disarmed with del_timer() which lets the following
>   code race against a concurrent timer expiry function.
> 
>   Solution: Use del_timer_sync() instead
> 
> - corkscrew_close() calls del_timer() unconditionally
> 
>   del_timer() is invoked even if the timer was never initialized. This
>   works by chance because the struct containing the timer is zeroed at
>   allocation time.
> 
>   Solution: Move the setup of the timer into corkscrew_setup().
> 
> Reported-by: Matthew Whitehead <tedheadster@gmail.com>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Applied, thanks Thomas.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

net/3com/3c515: Fix timer handling, prevent leaks and crashes Thomas Gleixner <tglx@linutronix.de> - 2016-12-11 18:40 +0100
  Re: net/3com/3c515: Fix timer handling, prevent leaks and crashes David Miller <davem@davemloft.net> - 2016-12-16 19:30 +0100

csiph-web