Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1543536

Re: [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE in case DT does not provide /chosen/bootargs

From Tony Lindgren <tony@atomide.com>
Newsgroups linux.kernel
Subject Re: [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE in case DT does not provide /chosen/bootargs
Date 2016-12-16 16:50 +0100
Message-ID <sP2VI-5xB-25@gated-at.bofh.it> (permalink)
References <sOp7Y-4Gu-27@gated-at.bofh.it> <sOZXP-3A4-5@gated-at.bofh.it> <sOZXQ-3A4-21@gated-at.bofh.it> <sP0hb-3GN-15@gated-at.bofh.it> <sP0hb-3GN-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

* Javier Martinez Canillas <javier@osg.samsung.com> [161216 04:54]:
> On 12/16/2016 09:48 AM, Pali Rohár wrote:
> >>> saying that it cause problems which need to be properly fixed. And
> >>> if fixing them is harder and will take more time, then correct
> >>> option is to revert 008a2ebcd677 due to breaking support for more
> >>> devices.
> >>
> >> If you think that others boards may have the same issue, then you
> >> could add an empty chosen node to omap3.dtsi. As I said I think that
> >> in practice this will only be needed for the machines using NOLO but
> >> you are right that in theory you could boot them using other
> >> bootloaders and having an empty node doesn't cause any harm anyway.
> > 
> > Should not be it part of any arm board? IIRC ATAG support is (or was) 
> > not omap3 specified.
> >
> 
> Yes, but you were talking about commit 008a2ebcd677 which only removed
> skeleton.dtsi usage for OMAP3 boards. The same can be done for other
> SoCs in its top level dtsi for the SoC family of course.

Yeah probaby best to add the empty chosen node to the ones that had
skeleton.dtsi removed.

And I think the code should print a warning if no chosen node is
found?

Regards,

Tony

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Pali Rohár <pali.rohar@gmail.com> - 2016-12-14 22:20 +0100
  Re: [PATCH] arm: dt: Initialize boot_command_line from  CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Pavel Machek <pavel@ucw.cz> - 2016-12-14 22:40 +0100
    Re: [PATCH] arm: dt: Initialize boot_command_line from  CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Tony Lindgren <tony@atomide.com> - 2016-12-14 22:50 +0100
  Re: [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE  in case DT does not provide /chosen/bootargs Javier Martinez Canillas <javier@dowhile0.org> - 2016-12-14 23:30 +0100
  Re: [PATCH] arm: dt: Initialize boot_command_line from  CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-12-15 01:00 +0100
    Re: [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Pali Rohár <pali.rohar@gmail.com> - 2016-12-15 01:10 +0100
      Re: [PATCH] arm: dt: Initialize boot_command_line from  CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-12-15 11:20 +0100
        Re: [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Pali Rohár <pali.rohar@gmail.com> - 2016-12-16 12:50 +0100
          Re: [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Pali Rohár <pali.rohar@gmail.com> - 2016-12-25 23:10 +0100
            Re: [PATCH] arm: dt: Initialize boot_command_line from  CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-02 15:00 +0100
      Re: [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Pali Rohár <pali.rohar@gmail.com> - 2016-12-16 12:50 +0100
        Re: [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE  in case DT does not provide /chosen/bootargs Javier Martinez Canillas <javier@osg.samsung.com> - 2016-12-16 13:20 +0100
          Re: [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Pali Rohár <pali.rohar@gmail.com> - 2016-12-16 13:40 +0100
            Re: [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE  in case DT does not provide /chosen/bootargs Javier Martinez Canillas <javier@osg.samsung.com> - 2016-12-16 13:40 +0100
              Re: [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Pali Rohár <pali.rohar@gmail.com> - 2016-12-16 14:00 +0100
                Re: [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE  in case DT does not provide /chosen/bootargs Javier Martinez Canillas <javier@osg.samsung.com> - 2016-12-16 14:00 +0100
                Re: [PATCH] arm: dt: Initialize boot_command_line from  CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Tony Lindgren <tony@atomide.com> - 2016-12-16 16:50 +0100
                Re: [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Pali Rohár <pali.rohar@gmail.com> - 2016-12-16 17:20 +0100
                Re: [PATCH] arm: dt: Initialize boot_command_line from  CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Tony Lindgren <tony@atomide.com> - 2016-12-16 17:30 +0100
                Re: [PATCH] arm: dt: Initialize boot_command_line from  CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-12-16 17:30 +0100
                Re: [PATCH] arm: dt: Initialize boot_command_line from  CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Mark Rutland <mark.rutland@arm.com> - 2016-12-16 18:00 +0100

csiph-web