[PATCH] dax: clarify driver_data ownership

Path	csiph.com!news.mixmin.net!feeds.phibee-telecom.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Dan Williams <dan.j.williams@intel.com>
Newsgroups	linux.kernel
Subject	[PATCH] dax: clarify driver_data ownership
Date	Thu, 15 Dec 2016 08:20:01 +0100
Message-ID	<sOyuB-2SW-9@gated-at.bofh.it> (permalink)
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.33,350,1477983600"; d="scan'208";a="798210323"
User-Agent	StGit/0.17.1-9-g687f
MIME-Version	1.0
Content-Type	text/plain; charset="utf-8"
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	31
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, Johannes Thumshirn <jthumshirn@suse.de>
X-Original-Date	Wed, 14 Dec 2016 22:59:59 -0800
X-Original-Message-ID	<148178519905.7385.6307065431345873736.stgit@dwillia2-desk3.amr.corp.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1542526

Show key headers only | View raw

Johannes points out that the warning in alloc_dax_region() seems to
imply that multiple devices might claim a dax region. In fact it's a
warning to driver developers that the dax core wants to own the
driver_data pointer for the hosting device of a dax_region. Add a
clarification.

Reported-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 drivers/dax/dax.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index d1641e69a088..c7b23d52f945 100644
--- a/drivers/dax/dax.c
+++ b/drivers/dax/dax.c
@@ -359,8 +359,13 @@ struct dax_region *alloc_dax_region(struct device *parent, int region_id,
 {
 	struct dax_region *dax_region;
 
+	/*
+	 * The DAX core assumes that it can store its private data in
+	 * parent->driver_data. This WARN is a reminder / safeguard for
+	 * developers of device-dax drivers.
+	 */
 	if (dev_get_drvdata(parent)) {
-		dev_WARN(parent, "dax core found drvdata already in use\n");
+		dev_WARN(parent, "dax core failed to setup private data\n");
 		return NULL;
 	}

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] dax: clarify driver_data ownership Dan Williams <dan.j.williams@intel.com> - 2016-12-15 08:20 +0100
  Re: [PATCH] dax: clarify driver_data ownership Johannes Thumshirn <jthumshirn@suse.de> - 2016-12-15 10:00 +0100

csiph-web