Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()

From	Richard Weinberger <richard@nod.at>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()
Date	2016-12-14 22:20 +0100
Message-ID	<sOp7Y-4Gu-29@gated-at.bofh.it> (permalink)
References	(1 earlier) <sjMka-7il-19@gated-at.bofh.it> <sjMNc-7My-5@gated-at.bofh.it> <smtuG-2XJ-25@gated-at.bofh.it> <sOnpv-2DO-7@gated-at.bofh.it> <sOp7X-4Gu-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi!

On 14.12.2016 22:09, Brian Norris wrote:
> On Wed, Dec 14, 2016 at 07:24:46PM +0000, Karl Beldan wrote:
>> On Wed, Sep 28, 2016 at 8:16 PM, Brian Norris
>> <computersforpeace@gmail.com> wrote:
>>> On Wed, Sep 21, 2016 at 12:15:31PM +0200, Boris Brezillon wrote:
>>>> On Wed, 21 Sep 2016 11:43:56 +0200
>>>> Daniel Walter <dwalter@sigma-star.at> wrote:
>>>>
>>>>> From: Richard Weinberger <richard@nod.at>
>>>>>
>>>>> If the master device has callbacks for _get/put_device()
>>>>> and this MTD has slaves a get_mtd_device() call on paritions
>>>>> will never issue the registered callbacks.
>>>>> Fix this by propagating _get/put_device() down.
>>>>
>>>> Brian, can we have this one queued for 4.9? I can't take it in my tree
>>>> if you want, but it's probably better if it's in the mtd tree.
>>>
>>> Applied this patch to l2-mtd.git
>>>
>>
>> I think this should also go into -stable.
> 
> Why? Do you have real use cases that are broken by this? I understand
> this is a problem, but I'm curious on how this satisfies the stable
> rules.
> 
> Also, note that this isn't a regression; it's been broken forever and
> apparently no one noticed. IMO that raises the bar a bit (but not
> impossibly so) for -stable.

Yes. AFAICT you can only trigger it using my "new" nandsim
which is not mainline so far.

Thanks,
//richard

Thread

Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device() Karl Beldan <karl.beldan@gmail.com> - 2016-12-14 20:30 +0100
  Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device() Brian Norris <computersforpeace@gmail.com> - 2016-12-14 22:20 +0100
    Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device() Richard Weinberger <richard@nod.at> - 2016-12-14 22:20 +0100
      Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device() Brian Norris <computersforpeace@gmail.com> - 2016-12-15 00:50 +0100
    Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device() Karl Beldan <karl.beldan@gmail.com> - 2016-12-15 08:10 +0100
      Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device() Richard Weinberger <richard@nod.at> - 2016-12-15 09:00 +0100
        Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device() Karl Beldan <karl.beldan@gmail.com> - 2016-12-28 20:00 +0100

csiph-web