RE: [PATCH] perf tools: ignore zombie process for user profile

From	"Liang, Kan" <kan.liang@intel.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] perf tools: ignore zombie process for user profile
Date	2016-12-14 20:30 +0100
Message-ID	<sOnpv-2DO-5@gated-at.bofh.it> (permalink)
References	<sOm0p-1bT-9@gated-at.bofh.it> <sOm0q-1bT-31@gated-at.bofh.it> <sOmD8-1S7-21@gated-at.bofh.it> <sOnfQ-2vz-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


.
> Em Wed, Dec 14, 2016 at 06:26:02PM +0000, Liang, Kan escreveu:
> > > On Wed, Dec 14, 2016 at 12:48:05PM -0500, kan.liang@intel.com wrote:
> > > > From: Kan Liang <kan.liang@intel.com> Zombie process is dead
> > > > process. It is meaningless to profile it.
> > > > It's better to ignore it for user profile.
> 
> > > I recently posted different patch for same issue:
> > >   http://marc.info/?l=linux-kernel&m=148153895827359&w=2
> 
> > The change as below make me confuse.
> > +	/* The system wide setup does not work with threads. */
> > +	if (!evsel->system_wide)
> > +		return false;
> > It looks the meaning of the comments is inconsistent with the code.
> 
> > Your original patch doesn't work well with the issue.
> > But if I change the above code as below, the issue is fixed.
> > 	if (evsel->system_wide)
> > 		return false;
> 
> yeah, Namhyung noticed that, Jiri sent a fixed patch, I have it already in my
> perf/core branch.
> 

That's great. Then Jiri's patch would work on my case.
Please ignore this patch.

Thanks,
Kan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] perf tools: ignore zombie process for user profile kan.liang@intel.com - 2016-12-14 19:00 +0100
  Re: [PATCH] perf tools: ignore zombie process for user profile Jiri Olsa <jolsa@redhat.com> - 2016-12-14 19:00 +0100
    RE: [PATCH] perf tools: ignore zombie process for user profile "Liang, Kan" <kan.liang@intel.com> - 2016-12-14 19:40 +0100
      Re: [PATCH] perf tools: ignore zombie process for user profile "acme@kernel.org" <acme@kernel.org> - 2016-12-14 20:20 +0100
        RE: [PATCH] perf tools: ignore zombie process for user profile "Liang, Kan" <kan.liang@intel.com> - 2016-12-14 20:30 +0100

csiph-web