Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1542041
| From | Hartley Sweeten <HartleyS@visionengravers.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH] drivers: staging: comedi: fix function prototypes |
| Date | 2016-12-14 17:50 +0100 |
| Message-ID | <sOkUG-ju-25@gated-at.bofh.it> (permalink) |
| References | <sOi6u-74m-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On December 14, 2016 6:42 AM, Piotr Gregor wrote: > Add names of parameters to function prototypes in comedi PCI. > Checkpatch reports now no errors. > > Signed-off-by: Piotr Gregor <piotrgregor@rsyncme.org> > --- > drivers/staging/comedi/comedi_pci.h | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/comedi/comedi_pci.h b/drivers/staging/comedi/comedi_pci.h > index 4005cc9..7dfd892 100644 > --- a/drivers/staging/comedi/comedi_pci.h > +++ b/drivers/staging/comedi/comedi_pci.h > @@ -34,18 +34,20 @@ > #define PCI_VENDOR_ID_RTD 0x1435 > #define PCI_VENDOR_ID_HUMUSOFT 0x186c > > -struct pci_dev *comedi_to_pci_dev(struct comedi_device *); > +struct pci_dev *comedi_to_pci_dev(struct comedi_device *dev); For the function prototypes I prefer no names for the "pointer" parameters. The "struct foo *" declaration is just as clear as "struct foo *bar". Thanks, Hartley
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] drivers: staging: comedi: fix function prototypes Piotr Gregor <piotrgregor@rsyncme.org> - 2016-12-14 14:50 +0100
RE: [PATCH] drivers: staging: comedi: fix function prototypes Hartley Sweeten <HartleyS@visionengravers.com> - 2016-12-14 17:50 +0100
Re: [PATCH] drivers: staging: comedi: fix function prototypes Ian Abbott <abbotti@mev.co.uk> - 2016-12-15 13:10 +0100
RE: [PATCH] drivers: staging: comedi: fix function prototypes Hartley Sweeten <HartleyS@visionengravers.com> - 2016-12-15 17:30 +0100
Re: [PATCH] drivers: staging: comedi: fix function prototypes Ian Abbott <abbotti@mev.co.uk> - 2016-12-15 13:10 +0100
RE: [PATCH] drivers: staging: comedi: fix function prototypes Hartley Sweeten <HartleyS@visionengravers.com> - 2016-12-15 18:40 +0100
csiph-web