Re: [RFC] perf/x86/intel/uncore: pmu->type->single_fixed question

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [RFC] perf/x86/intel/uncore: pmu->type->single_fixed question
Date	2016-12-14 13:00 +0100
Message-ID	<sOgo1-5Z6-23@gated-at.bofh.it> (permalink)
References	(1 earlier) <sJemS-7mo-31@gated-at.bofh.it> <sJhkJ-Ij-1@gated-at.bofh.it> <sJCyS-6te-21@gated-at.bofh.it> <sJCyS-6te-19@gated-at.bofh.it> <sNA5r-5yT-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Dec 12, 2016 at 02:49:03PM +0000, Liang, Kan wrote:
> 
> 
> > I really would prefer to move the thing to its own PMU.
> 
> The patch as below creates a new PMU to fix the issue.
> 
> Jirka, could you please try the patch on your machine?
> 
> 
> Thanks,
> Kan
> -------
> From 2de8b2eda6b54734e08a608b5fc8c367b94369d3 Mon Sep 17 00:00:00 2001
> From: Kan Liang <kan.liang@intel.com>
> Date: Mon, 12 Dec 2016 09:03:35 -0500
> Subject: [PATCH] perf/x86/intel/uncore: fix nonexistent clockticks event for
>  client uncore
> 
> The clockticks event can only be used by the first Cbox pmu. Other
> Cboxes don't allow to open clockticks event, eventhough it's announced
> via /sys/../events/..
> 
> For client uncore, there is only one clocktick fixed counter. Current
> kernel code forces that only the first box can access the fixed counter
> in uncore_pmu_event_init. But it doesn't take care of the the
> attr_groups. All the pmus of same type share the same attr_groups. If
> the clockticks event is set for the first box, user can also observe the
> event in other boxes.
> 
> The clocktick fixed counter is a standalone counter. It should be
> removed from the Cbox PMUs. A new type of PMU is added which only
> supports fixed counter events.
> 
> User observable changes with the patch.
> clockticks event is removed from Cbox. It will return unsupported, if
> uncore_cbox_0/clockticks/ is accessed. User may need to change their
> script to use uncore_clock/clockticks/ to instead.
> 
> Signed-off-by: Kan Liang <kan.liang@intel.com>

seems ok

Tested-by: Jiri Olsa <jolsa@redhat.com>

thanks,
jirka

Thread

RE: [RFC] perf/x86/intel/uncore: pmu->type->single_fixed question "Liang, Kan" <kan.liang@intel.com> - 2016-12-12 15:50 +0100
  Re: [RFC] perf/x86/intel/uncore: pmu->type->single_fixed question Jiri Olsa <jolsa@redhat.com> - 2016-12-14 13:00 +0100
    RE: [RFC] perf/x86/intel/uncore: pmu->type->single_fixed question "Liang, Kan" <kan.liang@intel.com> - 2016-12-20 19:10 +0100

csiph-web