Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1541838

Re: [PATCH] HID: add Asus macrokey support for Asus "Republic of Gamers" laptop

From Jiri Kosina <jikos@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] HID: add Asus macrokey support for Asus "Republic of Gamers" laptop
Date 2016-12-14 11:40 +0100
Message-ID <sOf8B-5jU-27@gated-at.bofh.it> (permalink)
References <sNydk-4lY-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, 12 Dec 2016, Chris Chiu wrote:

[ ... snip ... ]
> +static const struct hid_device_id asus_rog_devices[] = {
> +	{ HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_ROG_MACROKEY1) },
> +	{ HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_ROG_MACROKEY2) },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(hid, asus_rog_devices);

[ ... snip ... ]

In addition to what Benjamin said already, you also seem to be missing 
hid_have_special_driver[] entry for these VID/PIDs

Thanks,

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] HID: add Asus macrokey support for Asus "Republic of Gamers" laptop Chris Chiu <chiu@endlessm.com> - 2016-12-12 13:50 +0100
  Re: [PATCH] HID: add Asus macrokey support for Asus "Republic of  Gamers" laptop Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-12-13 09:20 +0100
  Re: [PATCH] HID: add Asus macrokey support for Asus "Republic of  Gamers" laptop Jiri Kosina <jikos@kernel.org> - 2016-12-14 11:40 +0100
    Re: [PATCH] HID: add Asus macrokey support for Asus "Republic of  Gamers" laptop Chris Chiu <chiu@endlessm.com> - 2016-12-14 18:00 +0100

csiph-web