Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1541798
| From | David Laight <David.Laight@ACULAB.COM> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH 3/3] secure_seq: use fast&secure siphash instead of slow&insecure md5 |
| Date | 2016-12-14 11:00 +0100 |
| Message-ID | <sOevU-4RP-21@gated-at.bofh.it> (permalink) |
| References | <sO5sB-7Vh-27@gated-at.bofh.it> <sO5sB-7Vh-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Jason A. Donenfeld
> Sent: 14 December 2016 00:17
> This gives a clear speed and security improvement. Rather than manually
> filling MD5 buffers, we simply create a layout by a simple anonymous
> struct, for which gcc generates rather efficient code.
...
> + const struct {
> + struct in6_addr saddr;
> + struct in6_addr daddr;
> + __be16 sport;
> + __be16 dport;
> + } __packed combined = {
> + .saddr = *(struct in6_addr *)saddr,
> + .daddr = *(struct in6_addr *)daddr,
> + .sport = sport,
> + .dport = dport
> + };
You need to look at the effect of marking this (and the other)
structures 'packed' on architectures like sparc64.
David
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 3/3] secure_seq: use fast&secure siphash instead of slow&insecure md5 "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-14 01:20 +0100 RE: [PATCH 3/3] secure_seq: use fast&secure siphash instead of slow&insecure md5 David Laight <David.Laight@ACULAB.COM> - 2016-12-14 11:00 +0100
csiph-web