[PATCH 11/13] fs: fix unsigned enum warning with gcc-4.2

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	[PATCH 11/13] fs: fix unsigned enum warning with gcc-4.2
Date	2016-12-16 12:00 +0100
Message-ID	<sOYp3-2rU-13@gated-at.bofh.it> (permalink)
References	<sOYp3-2rU-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

With arm-linux-gcc-4.2, almost every file we build in the kernel ends
up with this warning:

include/linux/fs.h:2648: warning: comparison of unsigned expression < 0 is always false

Later versions don't have this problem, but it's easy enough to
work around.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 include/linux/fs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index 398cf20a706d..782c2a292fd7 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2645,7 +2645,7 @@ static const char * const kernel_read_file_str[] = {
 
 static inline const char *kernel_read_file_id_str(enum kernel_read_file_id id)
 {
-	if (id < 0 || id >= READING_MAX_ID)
+	if ((unsigned)id >= READING_MAX_ID)
 		return kernel_read_file_str[READING_UNKNOWN];
 
 	return kernel_read_file_str[id];
-- 
2.9.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 11/13] fs: fix unsigned enum warning with gcc-4.2 Arnd Bergmann <arnd@arndb.de> - 2016-12-16 12:00 +0100

csiph-web