[PATCH] net: ipv6: check route protocol when deleting routes

From	Mantas Mikulėnas <grawity@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] net: ipv6: check route protocol when deleting routes
Date	2016-12-16 09:40 +0100
Message-ID	<sOWdz-135-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The protocol field is checked when deleting IPv4 routes, but ignored for
IPv6, which causes problems with routing daemons accidentally deleting
externally set routes (observed by multiple bird6 users).

This can be verified using `ip -6 route del <prefix> proto something`.

Signed-off-by: Mantas Mikulėnas <grawity@gmail.com>
---
 net/ipv6/route.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 947ed1ded026..ef6de8f9e5a2 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2163,6 +2163,8 @@ static int ip6_route_del(struct fib6_config *cfg)
 				continue;
 			if (cfg->fc_metric && cfg->fc_metric != rt->rt6i_metric)
 				continue;
+			if (cfg->fc_protocol && cfg->fc_protocol != rt->rt6i_protocol)
+				continue;
 			dst_hold(&rt->dst);
 			read_unlock_bh(&table->tb6_lock);
 
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: ipv6: check route protocol when deleting routes Mantas Mikulėnas <grawity@gmail.com> - 2016-12-16 09:40 +0100
  Re: [PATCH] net: ipv6: check route protocol when deleting routes David Miller <davem@davemloft.net> - 2016-12-18 03:40 +0100

csiph-web