Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1543312

Re: [PATCH] ubifs: add CONFIG_BLOCK dependency for encryption

Show all headers | View raw

Arnd,

On 16.12.2016 09:42, Arnd Bergmann wrote:
> This came up during the v4.10 merge window:
> 
> warning: (UBIFS_FS_ENCRYPTION) selects FS_ENCRYPTION which has unmet direct dependencies (BLOCK)
> fs/crypto/crypto.c: In function 'fscrypt_zeroout_range':
> fs/crypto/crypto.c:355:9: error: implicit declaration of function 'bio_alloc';did you mean 'd_alloc'? [-Werror=implicit-function-declaration]
>    bio = bio_alloc(GFP_NOWAIT, 1);
> 
> The easiest way out is to limit UBIFS_FS_ENCRYPTION to configurations
> that also enable BLOCK.

Thanks for the fix!
I'll queue this for -rc2.

In the long-run I'd like to remove the CONFIG_BLOCK dependency from fs/crypto/crypto.c
since UBIFS does not use the block related functions at all.

Thanks,
//richard

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ubifs: add CONFIG_BLOCK dependency for encryption Arnd Bergmann <arnd@arndb.de> - 2016-12-16 10:10 +0100
  Re: [PATCH] ubifs: add CONFIG_BLOCK dependency for encryption Richard Weinberger <richard@nod.at> - 2016-12-16 10:30 +0100
    Re: [PATCH] ubifs: add CONFIG_BLOCK dependency for encryption Christoph Hellwig <hch@infradead.org> - 2016-12-16 10:40 +0100

csiph-web