[PATCH] gpio: mxs: remove __init annotation

Path	csiph.com!feeder.erje.net!2.eu.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	[PATCH] gpio: mxs: remove __init annotation
Date	Fri, 16 Dec 2016 10:10:02 +0100
Message-ID	<sOWGC-1t7-7@gated-at.bofh.it> (permalink)
X-Mailer	git-send-email 2.9.0
X-Provags-ID	V03:K0:jQ3lMee8z9ks8IeQfJnV/QLKxeWKd5V8reSEkcaPcLVE5PN53qc tU7qxsG8fhnoTya9K/ty079GnluGy7DClI43qBZQT1ywaqARKu7e5OyX1UaPkQcXug7q/J1 AO0CGoKYPlXKCJwt+ueg1uJFSWEC/PqKBxtFiDVlMqVtzEEWBuNEnkDHDqvJW0TzvPvVrE4 qEX3JvtvI+0cVNnGlZzFQ==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:KauVAMC6L+k=:h9EKVb+ICnL2EvWlBDQvm9 V/KlnCCt7ZJC+9d1MTAdLcbjKDBzB8odv0HvXzm0MOK0LOLrfXJ5sSqoD+K1NoYqLVBqGloX2 UgXC8U09klMpOQU4Y04TqxPPgRbdh1Zsr97no6rQbXBlHX4Y5P+ucGzftFrfcAhNNydTY63Me x6XeSkOmA7luOv2Rx/cV83atkm/MgZCYjGd49NAjCeLV+oK8nwXNaiq6cUJmyomvi6ir0asNd pz3lvL9wQptDduKtpu5Qpjxgf0yvqRh99+lLAbjqz/koG5cGePDmBgGvu5Tlymav+7+vDrGZ5 ORTvvrt067nP7nZzTRiO2R3XFZJpn6CwjwrQ3RxBuRIqi+7NGBnZQhzXyL3EQiCQUwZFumXXQ CFwhxjm+IirMtYordewpWBWjfiVQa3LmgPFCYYLhrcD8tOLSGEjQ1HQsQ72o8/HtdlS8VSGpx tYhWBPABBqH+oRKHTtX4SCE2aLuLgaaqohbe9nxzZw2zbH+Xg6jzTcfkj/opBWHbm01kGJfW9 e0fMq74SNrzQlhDXQT+0ALVDEkG37eQH3LUoWZArNHUpCi5oe1av+lp4PFcLSurj7wa+/PQ5B YTEBEDQHSGfbDmYq40NS9yTZSd6NRWlFUIOb2xyqGlPYmsBe89Cqexjz4u11+fK1B4LMsGT2l aWOUpuNwqdSMlZ0dIvzV9d9XnB2/Sp2TOo9i2W8p6VgPkLyXIrlgYWsbq9//1e5V4kDo=
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	27
Organization	linux.* mail to news gateway
X-Original-Cc	Arnd Bergmann <arnd@arndb.de>, Marek Vasut <marex@denx.de>, Sascha Hauer <s.hauer@pengutronix.de>, Gregory Fong <gregory.0xf0@gmail.com>, Arvind Yadav <arvind.yadav.cs@gmail.com>, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Fri, 16 Dec 2016 10:08:14 +0100
X-Original-Message-ID	<20161216090825.2299257-1-arnd@arndb.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1543273

Show key headers only | View raw

Building with an old toolchain, I ran into this warning:

WARNING: vmlinux.o(.text+0x63eef0): Section mismatch in reference from the function mxs_gpio_probe() to the function .init.text:mxs_gpio_init_gc()

Clearly the annotation is wrong, since the function is called from the
non-init probe, so let's remove it.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpio/gpio-mxs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-mxs.c b/drivers/gpio/gpio-mxs.c
index 1e8fde8cb803..2292742eac8f 100644
--- a/drivers/gpio/gpio-mxs.c
+++ b/drivers/gpio/gpio-mxs.c
@@ -205,7 +205,7 @@ static int mxs_gpio_set_wake_irq(struct irq_data *d, unsigned int enable)
 	return 0;
 }
 
-static int __init mxs_gpio_init_gc(struct mxs_gpio_port *port, int irq_base)
+static int mxs_gpio_init_gc(struct mxs_gpio_port *port, int irq_base)
 {
 	struct irq_chip_generic *gc;
 	struct irq_chip_type *ct;
-- 
2.9.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] gpio: mxs: remove __init annotation Arnd Bergmann <arnd@arndb.de> - 2016-12-16 10:10 +0100
  Re: [PATCH] gpio: mxs: remove __init annotation Linus Walleij <linus.walleij@linaro.org> - 2016-12-30 09:10 +0100

csiph-web