Re: [PATCH 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

From	Mark Greer <mgreer@animalcreek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel
Date	2016-12-16 02:20 +0100
Message-ID	<sOPlM-4TI-5@gated-at.bofh.it> (permalink)
References	<sOMQW-38F-23@gated-at.bofh.it> <sOMQW-38F-31@gated-at.bofh.it>
Organization	Animal Creek Technologies, Inc.

Show all headers | View raw

On Thu, Dec 15, 2016 at 05:30:44PM -0500, Geoff Lansberry wrote:
> From: Jaret Cantu <jaret.cantu@timesys.com>
> 
> Repeated polling attempts cause a NULL dereference error to occur.
> This is because the curent state of the trf7970a is reading but
> a request has been made to send a command.
> 
> The solution is to properly kill the waiting reading (workqueue)
> before failing on the send.

Maybe its just me but I find this description a little hard to grok.
Mind reworking it?

The patch itself looks fine.

Thanks,

Mark
--

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel Geoff Lansberry <geoff@kuvee.com> - 2016-12-15 23:40 +0100
  Re: [PATCH 3/3] nfc: trf7970a: Prevent repeated polling from  crashing the kernel Mark Greer <mgreer@animalcreek.com> - 2016-12-16 02:20 +0100

csiph-web