Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1543154

Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

Show all headers | View raw

Hi Geoff.

On Thu, Dec 15, 2016 at 05:30:42PM -0500, Geoff Lansberry wrote:
> From: Geoff Lansberry <geoff@kuvee.com>

Please add an informative commit description to all of your commits.
No matter how trivial this patch may seem to you now, it may not be
to others (or to you in a few years).

> diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c
> index 26c9dbb..2d2a077 100644
> --- a/drivers/nfc/trf7970a.c
> +++ b/drivers/nfc/trf7970a.c

> @@ -1181,27 +1180,37 @@ static int trf7970a_in_config_rf_tech(struct trf7970a *trf, int tech)
>  	switch (tech) {
>  	case NFC_DIGITAL_RF_TECH_106A:
>  		trf->iso_ctrl_tech = TRF7970A_ISO_CTRL_14443A_106;
> -		trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_DEPTH_OOK;
> +		trf->modulator_sys_clk_ctrl =
> +			(trf->modulator_sys_clk_ctrl & 0xF8) |

nit: s/0xF8/0xf8/ please (for consistency with the rest of the file.).

Otherwise, it looks good.

Thanks,

Mark

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock Geoff Lansberry <geoff@kuvee.com> - 2016-12-15 23:40 +0100
  Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock Mark Greer <mgreer@animalcreek.com> - 2016-12-16 02:10 +0100
  Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock Rob Herring <robh@kernel.org> - 2016-12-19 23:40 +0100
    Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock Geoff Lansberry <geoff@kuvee.com> - 2016-12-20 00:30 +0100
      Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock Rob Herring <robh@kernel.org> - 2016-12-22 19:50 +0100

csiph-web