RE: [virtio-dev] Re: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver

From	"Gonglei (Arei)" <arei.gonglei@huawei.com>
Newsgroups	linux.kernel
Subject	RE: [virtio-dev] Re: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver
Date	2016-12-16 01:50 +0100
Message-ID	<sOOSK-4rO-9@gated-at.bofh.it> (permalink)
References	(2 earlier) <sOjOV-88T-15@gated-at.bofh.it> <sOspb-7l2-13@gated-at.bofh.it> <sOsyR-7om-17@gated-at.bofh.it> <sOsIy-7Hm-5@gated-at.bofh.it> <sOHoe-87a-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Michael,

>
> >
> >
> > > Subject: RE: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver
> > >
> > > On Thursday, December 15, 2016 8:45 AM, Gonglei (Arei) Wrote:
> > > < > > diff --git a/drivers/crypto/virtio/virtio_crypto_core.c
> > > < > b/drivers/crypto/virtio/virtio_crypto_core.c
> > > < > > new file mode 100644
> > > < > > index 0000000..c0854a1
> > > < > > --- /dev/null
> > > < > > +++ b/drivers/crypto/virtio/virtio_crypto_core.c
> > > < > > @@ -0,0 +1,474 @@
> > > < > [..]
> > > < > > +
> > > < > > +static void virtcrypto_dataq_callback(struct virtqueue *vq)
> > > < > > +{
> > > < > > +	struct virtio_crypto *vcrypto = vq->vdev->priv;
> > > < > > +	struct virtio_crypto_request *vc_req;
> > > < > > +	unsigned long flags;
> > > < > > +	unsigned int len;
> > > < > > +	struct ablkcipher_request *ablk_req;
> > > < > > +	int error;
> > > < > > +
> > > < > > +	spin_lock_irqsave(&vcrypto->lock, flags);
> > > < >
> > > < > Would it make sense to use a per virtqueue lock
> > > < > like in virtio_blk for example instead of locking on the whole
> > > < > device? OK, it seems you use only one dataqueue, so it
> > > < > may not be that relevant.
> > > < >
> > > < Currently yes, both the backend device (cryptodev-backend-builtin)
> > > < and the frontend driver use one dataqueue.
> > > <
> > >
> > > I think it makes sense to use per virtqueue lock here though it only uses one
> > > queue so far,
> > > but in the spec we already have multi queues support.
> > >
> > Yes, I agree. Will do that in V8 soon.
> > Hope to catch up with Michael's pull request for 4.10.
> >
> > Regards,
> > -Gonglei
> 
> I merged v7, this change will have to wait. Sorry.
> 
That's OK. Thanks!

I can post a separate patch after this pull request. 

Regards,
-Gonglei

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v7 0/1] virtio-crypto: add Linux driver Gonglei <arei.gonglei@huawei.com> - 2016-12-14 13:00 +0100
  Re: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver Halil Pasic <pasic@linux.vnet.ibm.com> - 2016-12-14 16:40 +0100
    RE: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver "Gonglei (Arei)" <arei.gonglei@huawei.com> - 2016-12-15 01:50 +0100
      RE: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver "Zeng, Xin" <xin.zeng@intel.com> - 2016-12-15 02:00 +0100
        RE: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver "Gonglei (Arei)" <arei.gonglei@huawei.com> - 2016-12-15 02:10 +0100
          Re: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver "Michael S. Tsirkin" <mst@redhat.com> - 2016-12-15 17:50 +0100
            RE: [virtio-dev] Re: [Qemu-devel] [PATCH v7 1/1] crypto: add  virtio-crypto driver "Gonglei (Arei)" <arei.gonglei@huawei.com> - 2016-12-16 01:50 +0100

csiph-web