Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1543105

Re: [PATCH 2/2] media: omap3isp change to devm for resources

Show all headers | View raw

Hi Shuah,

Thank you for the patch.

Sakari has submitted a similar patch as part of his kref series. Please use it 
as a base point and rework it if you want to get it merged separately. I've 
reviewed the patch and left quite a few comments that need to be addressed.

On Thursday 15 Dec 2016 12:40:08 Shuah Khan wrote:
> Using devm resources that have external dependencies such as a dev
> for a file handler could result in devm resources getting released
> durin unbind while an application has the file open holding pointer
> to the devm resource. This results in use-after-free errors when the
> application exits.
> 
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
>  drivers/media/platform/omap3isp/isp.c         | 71 ++++++++++++++++--------
>  drivers/media/platform/omap3isp/ispccp2.c     | 10 +++-
>  drivers/media/platform/omap3isp/isph3a_aewb.c | 21 +++++---
>  drivers/media/platform/omap3isp/isph3a_af.c   | 21 +++++---
>  drivers/media/platform/omap3isp/isphist.c     |  5 +-
>  5 files changed, 92 insertions(+), 36 deletions(-)

-- 
Regards,

Laurent Pinchart

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] omap3 devm usage removal  Shuah Khan <shuahkh@osg.samsung.com> - 2016-12-15 20:50 +0100
  [PATCH 2/2] media: omap3isp change to devm for resources Shuah Khan <shuahkh@osg.samsung.com> - 2016-12-15 20:50 +0100
    Re: [PATCH 2/2] media: omap3isp change to devm for resources Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-12-15 23:40 +0100
      Re: [PATCH 2/2] media: omap3isp change to devm for resources Shuah Khan <shuahkh@osg.samsung.com> - 2016-12-16 00:00 +0100
        Re: [PATCH 2/2] media: omap3isp change to devm for resources Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-12-16 00:10 +0100
    Re: [PATCH 2/2] media: omap3isp change to devm for resources Hans Verkuil <hverkuil@xs4all.nl> - 2016-12-16 12:50 +0100
      Re: [PATCH 2/2] media: omap3isp change to devm for resources Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-12-16 13:30 +0100
        Re: [PATCH 2/2] media: omap3isp change to devm for resources Hans Verkuil <hverkuil@xs4all.nl> - 2016-12-16 13:40 +0100
  [PATCH 1/2] media: omap3isp fix media_entity_cleanup() after media device unregister Shuah Khan <shuahkh@osg.samsung.com> - 2016-12-15 20:50 +0100
    Re: [PATCH 1/2] media: omap3isp fix media_entity_cleanup() after media device unregister Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-12-15 23:40 +0100
      Re: [PATCH 1/2] media: omap3isp fix media_entity_cleanup() after  media device unregister Shuah Khan <shuahkh@osg.samsung.com> - 2016-12-16 00:00 +0100

csiph-web