Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1543079

Re: default 0 if KASAN expression not working in kbuild

Show all headers | View raw

On 12/15/16 10:09, Nikolay Borisov wrote:
> Hello,
> 
> I was doing some kasan-related debugging and when I enabled it I started
> getting warnings for large stackframes. So CONFIG_FRAME_WARN has :
> 
> int "Warn for stack frames larger than (needs gcc 4.4)"
>     range 0 8192
>     default 0 if KASAN
>     default 2048 if GCC_PLUGIN_LATENT_ENTROPY
>     default 1024 if !64BIT
>     default 2048 if 64BIT
> 
> This means that frame_warns should effectively be disabled when kasan is
> enabled. However in my case this is not the situation.
> http://sprunge.us/FiGf here is the config file. It does have
> CONFIG_KASAN=y and CONFIG_FRAME_WARN=1024 . And even this is erroneous
> since it's a 64bit kernel, so it should be 2k. I haven't manually set
> the limit to 1k either.

Yeah, it set FRAME_WARN=1024 for me also.

It seems to be dependent on order of kconfig symbols in
lib/Kconfig.debug.

If I move the line:
  source "lib/Kconfig.kasan"
to just after this line:
  menu "Compile-time checks and compiler options"
it seems to work for me.

Can you test the patch below?
-- 
~Randy



From: Randy Dunlap <rdunlap@infradead.org>

Move the KASAN kconfig symbols to above where they are used
so that their chosen values are used later.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
 lib/Kconfig.debug |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- lnx-49.orig/lib/Kconfig.debug
+++ lnx-49/lib/Kconfig.debug
@@ -117,6 +117,8 @@ endmenu # "printk and dmesg options"
 
 menu "Compile-time checks and compiler options"
 
+source "lib/Kconfig.kasan"
+
 config DEBUG_INFO
 	bool "Compile the kernel with debug info"
 	depends on DEBUG_KERNEL && !COMPILE_TEST
@@ -695,8 +697,6 @@ config DEBUG_STACKOVERFLOW
 
 source "lib/Kconfig.kmemcheck"
 
-source "lib/Kconfig.kasan"
-
 endmenu # "Memory Debugging"
 
 config ARCH_HAS_KCOV

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

default 0 if KASAN expression not working in kbuild Nikolay Borisov <n.borisov.lkml@gmail.com> - 2016-12-15 19:20 +0100
  Re: default 0 if KASAN expression not working in kbuild Randy Dunlap <rdunlap@infradead.org> - 2016-12-15 22:40 +0100
    Re: default 0 if KASAN expression not working in kbuild Nikolay Borisov <n.borisov.lkml@gmail.com> - 2016-12-16 09:00 +0100
    Re: default 0 if KASAN expression not working in kbuild Nikolay Borisov <n.borisov.lkml@gmail.com> - 2016-12-16 09:00 +0100
  Re: default 0 if KASAN expression not working in kbuild Michal Marek <mmarek@suse.com> - 2016-12-19 12:00 +0100

csiph-web