Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1542838

Re: [PATCH] sample/bpf: Make perf_event_read() static

Show all headers | View raw

On 12/15/2016 04:29 PM, Arnaldo Carvalho de Melo wrote:
>
> While testing Joe's conversion of samples/bpf/ to use tools/lib/bpf/ I
> noticed some warnings, do you guys mind if I put patches like the one
> below in my tree, pushing to Ingo soon?
>
> Or is there anything subtle against doing so?

Fwiw, no objections from my side, there is currently nothing in
net/net-next tree that could cause conflicts regarding the below
change, so should be good to take this route instead.

> ----
>
> While building samples/bpf/ on a Fedora Rawhide container, with
> clang/llvm 3.9 I noticed this:
>
> root@1e797fdfbf4f linux]# make -j4 O=/tmp/build/linux/ samples/bpf/
> make[1]: Entering directory '/tmp/build/linux'
>    CHK     include/config/kernel.release
>    GEN     ./Makefile
>    CHK     include/generated/uapi/linux/version.h
>    Using /git/linux as source for kernel
> <SNIP>
>    HOSTCC  samples/bpf/trace_output_user.o
> /git/linux/samples/bpf/trace_output_user.c:64:6: warning: no previous
> prototype for 'perf_event_read' [-Wmissing-prototypes]
>   void perf_event_read(print_fn fn)
>        ^~~~~~~~~~~~~~~
>    HOSTLD  samples/bpf/trace_output
> make[1]: Leaving directory '/tmp/build/linux'
>
> Shutup the compiler by setting that function as static.
>
> Cc: Alexei Starovoitov <ast@fb.com>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Wang Nan <wangnan0@huawei.com>,
> Cc: Joe Stringer <joe@ovn.org>
> Link: http://lkml.kernel.org/n/tip-2wkr4ymwhdie0stbkbiyplt5@git.kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Acked-by: Daniel Borkmann <daniel@iogearbox.net>

Thanks,
Daniel

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] sample/bpf: Make perf_event_read() static Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-12-15 16:30 +0100
  Re: [PATCH] sample/bpf: Make perf_event_read() static Daniel Borkmann <daniel@iogearbox.net> - 2016-12-15 16:50 +0100
    Re: [PATCH] sample/bpf: Make perf_event_read() static Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-12-15 17:00 +0100
  [tip:perf/urgent] samples/bpf: Make perf_event_read() static tip-bot for Arnaldo Carvalho de Melo <tipbot@zytor.com> - 2016-12-20 20:30 +0100

csiph-web