Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1542655

[PATCH net-next] ixgbevf: fix 'Etherleak' in ixgbevf

From Weilong Chen <chenweilong@huawei.com>
Newsgroups linux.kernel
Subject [PATCH net-next] ixgbevf: fix 'Etherleak' in ixgbevf
Date 2016-12-15 12:40 +0100
Message-ID <sOCye-5bS-21@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


Nessus report the vf appears to leak memory in network packets.
Fix this by padding all small packets manually.

And the CVE-2003-0001.
https://ofirarkin.files.wordpress.com/2008/11/atstake_etherleak_report.pdf

Signed-off-by: Weilong Chen <chenweilong@huawei.com>
---
 drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
index 6d4bef5..137a154 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
@@ -3654,6 +3654,13 @@ static int ixgbevf_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
 		return NETDEV_TX_OK;
 	}
 
+	/* On PCI/PCI-X HW, if packet size is less than ETH_ZLEN,
+	 * packets may get corrupted during padding by HW.
+	 * To WA this issue, pad all small packets manually.
+	 */
+	if (eth_skb_pad(skb))
+		return NETDEV_TX_OK;
+
 	tx_ring = adapter->tx_ring[skb->queue_mapping];
 
 	/* need: 1 descriptor per page * PAGE_SIZE/IXGBE_MAX_DATA_PER_TXD,
-- 
1.7.12

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH net-next] ixgbevf: fix 'Etherleak' in ixgbevf Weilong Chen <chenweilong@huawei.com> - 2016-12-15 12:40 +0100
  Re: [PATCH net-next] ixgbevf: fix 'Etherleak' in ixgbevf Alexander Duyck <alexander.duyck@gmail.com> - 2016-12-15 17:20 +0100
    Re: [PATCH net-next] ixgbevf: fix 'Etherleak' in ixgbevf Weilong Chen <chenweilong@huawei.com> - 2016-12-20 13:40 +0100
      Re: [PATCH net-next] ixgbevf: fix 'Etherleak' in ixgbevf Alexander Duyck <alexander.duyck@gmail.com> - 2016-12-20 17:40 +0100
        Re: [PATCH net-next] ixgbevf: fix 'Etherleak' in ixgbevf Weilong Chen <chenweilong@huawei.com> - 2016-12-21 02:50 +0100
          Re: [PATCH net-next] ixgbevf: fix 'Etherleak' in ixgbevf Alexander Duyck <alexander.duyck@gmail.com> - 2016-12-21 03:30 +0100
            Re: [PATCH net-next] ixgbevf: fix 'Etherleak' in ixgbevf Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-12-22 03:10 +0100
              Re: [PATCH net-next] ixgbevf: fix 'Etherleak' in ixgbevf Alexander Duyck <alexander.duyck@gmail.com> - 2016-12-22 19:00 +0100

csiph-web