Re: [PATCH] libnvdimm, dax: replace mutex_is_locked() warnings with lockdep_assert_held

From	Johannes Thumshirn <jthumshirn@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] libnvdimm, dax: replace mutex_is_locked() warnings with lockdep_assert_held
Date	2016-12-15 10:00 +0100
Message-ID	<sOA3n-3DP-3@gated-at.bofh.it> (permalink)
References	<sOyEh-2VZ-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Dec 14, 2016 at 11:17:46PM -0800, Dan Williams wrote:
> For warnings that should only ever trigger during development and
> testing replace WARN statements with lockdep_assert_held. The lockdep
> pattern is prevalent, and these paths are are well covered by libnvdimm
> + dax unit tests.
> 
> Reported-by: Johannes Thumshirn <jthumshirn@suse.de>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---

Thanks Dan,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] libnvdimm,  dax: replace mutex_is_locked() warnings with lockdep_assert_held Dan Williams <dan.j.williams@intel.com> - 2016-12-15 08:30 +0100
  Re: [PATCH] libnvdimm, dax: replace mutex_is_locked() warnings with  lockdep_assert_held Johannes Thumshirn <jthumshirn@suse.de> - 2016-12-15 10:00 +0100

csiph-web