Re: [PATCH 4/5] firmware: add SmPL report for custom fallback mechanism

From	Milo Kim <woogyom.kim@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/5] firmware: add SmPL report for custom fallback mechanism
Date	2016-12-14 03:00 +0100
Message-ID	<sO71o-di-15@gated-at.bofh.it> (permalink)
References	<sNLDz-4f3-3@gated-at.bofh.it> <sNRSF-7Zv-3@gated-at.bofh.it> <sNLDz-4f3-15@gated-at.bofh.it> <sNRSF-7Zv-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Jacek,

On 12/13/2016 06:44 PM, Jacek Anaszewski wrote:
>
> Could you please verify if leds-lp55xx-common.c driver
> really needs a custom firmware loading fallback mechanism?

Thanks for sharing this. The lp55xx-common uses this mechanism to load 
and run LED effect manually, so this could be a misuse case.
I think the right solution is providing device attributes.

At this moment, four drivers use lp55xx-common code.

- lp5521, lp5523: OK if we do not support FW loading fallback mechanism
- lp5562, lp8501: need to create additional sysfs alternatively.

However, we should be careful because I'm not sure this modification 
will generate the regression (breaking the user-space) or not.

Best regards,
Milo

Thread

[PATCH 4/5] firmware: add SmPL report for custom fallback mechanism "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-12-13 04:10 +0100
  Re: [PATCH 4/5] firmware: add SmPL report for custom fallback  mechanism Julia Lawall <julia.lawall@lip6.fr> - 2016-12-13 07:20 +0100
  Re: [PATCH 4/5] firmware: add SmPL report for custom fallback mechanism Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-12-13 10:50 +0100
    Re: [PATCH 4/5] firmware: add SmPL report for custom fallback  mechanism Milo Kim <woogyom.kim@gmail.com> - 2016-12-14 03:00 +0100
      Re: [PATCH 4/5] firmware: add SmPL report for custom fallback  mechanism "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-12-16 10:40 +0100

csiph-web