Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1541556

Re: [PATCH v2] memory_hotplug: zone_can_shift() returns boolean value

Show all headers | View raw

On Tue, Dec 13, 2016 at 03:29:49PM -0500, Yasuaki Ishimatsu wrote:
>online_{kernel|movable} is used to change the memory zone to
>ZONE_{NORMAL|MOVABLE} and online the memory.
>
>To check that memory zone can be changed, zone_can_shift() is used.
>Currently the function returns minus integer value, plus integer
>value and 0. When the function returns minus or plus integer value,
>it means that the memory zone can be changed to ZONE_{NORNAL|MOVABLE}.
>
>But when the function returns 0, there is 2 meanings.
>
>One of the meanings is that the memory zone does not need to be changed.
>For example, when memory is in ZONE_NORMAL and onlined by online_kernel
>the memory zone does not need to be changed.
>
>Another meaning is that the memory zone cannot be changed. When memory
>is in ZONE_NORMAL and onlined by online_movable, the memory zone may
>not be changed to ZONE_MOVALBE due to memory online limitation(see
>Documentation/memory-hotplug.txt). In this case, memory must not be
>onlined.
>
>The patch changes the return type of zone_can_shift() so that memory
>is not onlined when memory zone cannot be changed.

Reviewed-by: Reza Arbab <arbab@linux.vnet.ibm.com>

-- 
Reza Arbab

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] memory_hotplug: zone_can_shift() returns boolean value Yasuaki Ishimatsu <yasu.isimatu@gmail.com> - 2016-12-13 21:40 +0100
  Re: [PATCH v2] memory_hotplug: zone_can_shift() returns boolean value Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-12-14 00:20 +0100

csiph-web