Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1541488

Re: [GIT PULL] Block core changes for 4.10

From Jens Axboe <axboe@kernel.dk>
Newsgroups linux.kernel
Subject Re: [GIT PULL] Block core changes for 4.10
Date 2016-12-13 21:20 +0100
Message-ID <sO1Im-5Bt-17@gated-at.bofh.it> (permalink)
References <sNo4i-6w8-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 12/11/2016 06:52 PM, Jens Axboe wrote:
> Note that this pull will throw 3 trivial merge conflicts, since we had
> patches that went into mainline after 4.9-rc1 (upon which this branch is
> based), and one that will not show up in block/blk-flush.c. The latter
> is due to a fix that went in for the flush code using an old request
> flag that is now changed to a per-request one. To ensure that this all
> goes smoothly, I just merged 4.9 with this branch and provide that as a
> reference:
> 
>   git://git.kernel.dk/linux-block.git for-4.10/merge
> 
> But really, the only one you to watch for is this line in
> block/blk-flush.c:
> 
>         /* for avoiding double accounting */
> 	rq->cmd_flags &= ~REQ_STARTED;
> 
> which should now be:
> 
>         rq->rq_flags &= ~RQF_STARTED;
> 
> and the three merge conflicts that do show up are trivially resolvable.

Since you have merged trees since that contain block drivers, you are
going to get a new merge conflict. There's one with mmc block now, which
is again just a switch from rq->cmd_flags to rq->rq_flags and using
RQF_foo instead of REQ_foo.

-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[GIT PULL] Block core changes for 4.10 Jens Axboe <axboe@kernel.dk> - 2016-12-12 03:00 +0100
  Re: [GIT PULL] Block core changes for 4.10 Jens Axboe <axboe@kernel.dk> - 2016-12-13 21:20 +0100
  Re: [GIT PULL] Block core changes for 4.10 Stephen Rothwell <sfr@canb.auug.org.au> - 2016-12-14 00:40 +0100

csiph-web