Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1541399

Re: [PATCH v6 1/2] Add OV5647 device tree documentation

From Pavel Machek <pavel@ucw.cz>
Newsgroups linux.kernel
Subject Re: [PATCH v6 1/2] Add OV5647 device tree documentation
Date 2016-12-13 20:10 +0100
Message-ID <sO0CB-4Zy-1@gated-at.bofh.it> (permalink)
References <sNWpk-2jB-27@gated-at.bofh.it> <sNWpk-2jB-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Tue 2016-12-13 14:32:36, Ramiro Oliveira wrote:
> Create device tree bindings documentation.
> 
> Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com>
> ---
>  .../devicetree/bindings/media/i2c/ov5647.txt       | 35 ++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov5647.txt b/Documentation/devicetree/bindings/media/i2c/ov5647.txt
> new file mode 100644
> index 0000000..46e5e30
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ov5647.txt
> @@ -0,0 +1,35 @@
> +Omnivision OV5647 raw image sensor
> +---------------------------------
> +
> +OV5647 is a raw image sensor with MIPI CSI-2 and CCP2 image data interfaces
> +and CCI (I2C compatible) control bus.
> +
> +Required properties:
> +
> +- compatible	: "ovti,ov5647";
> +- reg		: I2C slave address of the sensor;
> +- clocks	: Reference to the xclk clock.
> +- clock-names	: Should be "xclk".
> +- clock-frequency: Frequency of the xclk clock

Nit pick: you end the lines here with ';', '.' and nothing. Pick one
:-).

Otherwise it looks good.

Acked-by: Pavel Machek <pavel@ucw.cz>
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v6 0/2] Add support for Omnivision OV5647 Ramiro Oliveira <Ramiro.Oliveira@synopsys.com> - 2016-12-13 15:40 +0100
  [PATCH v6 1/2] Add OV5647 device tree documentation Ramiro Oliveira <Ramiro.Oliveira@synopsys.com> - 2016-12-13 15:40 +0100
    Re: [PATCH v6 1/2] Add OV5647 device tree documentation Pavel Machek <pavel@ucw.cz> - 2016-12-13 20:10 +0100
    Re: [PATCH v6 1/2] Add OV5647 device tree documentation Rob Herring <robh@kernel.org> - 2016-12-19 18:50 +0100
  [PATCH v6 2/2] Add support for OV5647 sensor. Ramiro Oliveira <Ramiro.Oliveira@synopsys.com> - 2016-12-13 15:40 +0100
    Re: [PATCH v6 2/2] Add support for OV5647 sensor. Pavel Machek <pavel@ucw.cz> - 2016-12-13 20:10 +0100

csiph-web