Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1540221

Re: [PATCH] mm: fadvise: avoid expensive remote LRU cache draining after FADV_DONTNEED

Show all headers | View raw

On Sat, Dec 10, 2016 at 12:26:58PM -0500, Johannes Weiner wrote:
> When FADV_DONTNEED cannot drop all pages in the range, it observes
> that some pages might still be on per-cpu LRU caches after recent
> instantiation and so initiates remote calls to all CPUs to flush their
> local caches. However, in most cases, the fadvise happens from the
> same context that instantiated the pages, and any pre-LRU pages in the
> specified range are most likely sitting on the local CPU's LRU cache,
> and so in many cases this results in unnecessary remote calls, which,
> in a loaded system, can hold up the fadvise() call significantly.
> 
> Try to avoid the remote call by flushing the local LRU cache before
> even attempting to invalidate anything. It's a cheap operation, and
> the local LRU cache is the most likely to hold any pre-LRU pages in
> the specified fadvise range.
> 
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

Acked-by: Mel Gorman <mgorman@suse.de>

-- 
Mel Gorman
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mm: fadvise: avoid expensive remote LRU cache draining after FADV_DONTNEED Johannes Weiner <hannes@cmpxchg.org> - 2016-12-10 18:30 +0100
  Re: [PATCH] mm: fadvise: avoid expensive remote LRU cache draining  after FADV_DONTNEED Vlastimil Babka <vbabka@suse.cz> - 2016-12-12 10:30 +0100
    Re: [PATCH] mm: fadvise: avoid expensive remote LRU cache draining  after FADV_DONTNEED Johannes Weiner <hannes@cmpxchg.org> - 2016-12-12 17:00 +0100
      Re: [PATCH] mm: fadvise: avoid expensive remote LRU cache draining  after FADV_DONTNEED Vlastimil Babka <vbabka@suse.cz> - 2016-12-13 13:40 +0100
        [PATCH v2] mm: fadvise: avoid expensive remote LRU cache draining  after FADV_DONTNEED Johannes Weiner <hannes@cmpxchg.org> - 2016-12-14 22:10 +0100
          Re: [PATCH v2] mm: fadvise: avoid expensive remote LRU cache draining after FADV_DONTNEED "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-12-15 05:20 +0100
  Re: [PATCH] mm: fadvise: avoid expensive remote LRU cache draining  after FADV_DONTNEED Mel Gorman <mgorman@suse.de> - 2016-12-12 11:00 +0100

csiph-web