Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1540210

Re: [patch] nvme-fabrics: correct some printk information

From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject Re: [patch] nvme-fabrics: correct some printk information
Date 2016-12-12 10:40 +0100
Message-ID <sNvfr-2B3-1@gated-at.bofh.it> (permalink)
References (2 earlier) <sMV2h-5NE-13@gated-at.bofh.it> <sMW82-6F8-17@gated-at.bofh.it> <sMWUp-6V9-1@gated-at.bofh.it> <sMX45-7du-5@gated-at.bofh.it> <sMYjv-7Ui-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Sat, Dec 10, 2016 at 02:24:22PM -0800, Joe Perches wrote:
> On Sun, 2016-12-11 at 00:07 +0300, Dan Carpenter wrote:
> > On Sat, Dec 10, 2016 at 12:54:50PM -0800, Joe Perches wrote:
> > > diff -u -p drivers//dma/pxa_dma.c /tmp/nothing//dma/pxa_dma.c
> > > --- drivers//dma/pxa_dma.c
> > > +++ /tmp/nothing//dma/pxa_dma.c
> > > @@ -640,9 +640,6 @@ static unsigned int clear_chan_irq(struc
> > >  	dcsr = phy_readl_relaxed(phy, DCSR);
> > >  	phy_writel(phy, dcsr, DCSR);
> > >  	if ((dcsr & PXA_DCSR_BUSERR) && (phy->vchan))
> > > -		dev_warn(&phy->vchan->vc.chan.dev->device,
> > > -			 "%s(chan=%p): PXA_DCSR_BUSERR\n",
> > > -			 __func__, &phy->vchan);
> > 
> > That's not a defect.  We're getting the address of vchan.  I don't get
> > it?
> 
> $ git grep -n -w vchan drivers/dma/pxa*
> drivers/dma/pxa_dma.c:103:      struct pxad_chan        *vchan;

I'm not sure what you're saying here still.  This code works as
intended.  We're not printing a stack address.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch] nvme-fabrics: correct some printk information Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-10 10:20 +0100
  Re: [patch] nvme-fabrics: correct some printk information Joe Perches <joe@perches.com> - 2016-12-10 12:30 +0100
    Re: [patch] nvme-fabrics: correct some printk information Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-10 20:00 +0100
      Re: [patch] nvme-fabrics: correct some printk information Julia Lawall <julia.lawall@lip6.fr> - 2016-12-10 21:10 +0100
        Re: [patch] nvme-fabrics: correct some printk information Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-10 21:30 +0100
        Re: [patch] nvme-fabrics: correct some printk information Joe Perches <joe@perches.com> - 2016-12-10 22:00 +0100
          Re: [patch] nvme-fabrics: correct some printk information Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-10 22:10 +0100
            Re: [patch] nvme-fabrics: correct some printk information Joe Perches <joe@perches.com> - 2016-12-10 23:30 +0100
              Re: [patch] nvme-fabrics: correct some printk information Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-12 10:40 +0100
                Re: [patch] nvme-fabrics: correct some printk information Julia Lawall <julia.lawall@lip6.fr> - 2016-12-12 16:50 +0100
                Re: [patch] nvme-fabrics: correct some printk information Joe Perches <joe@perches.com> - 2016-12-12 17:00 +0100
          Re: [patch] nvme-fabrics: correct some printk information Julia Lawall <julia.lawall@lip6.fr> - 2016-12-10 23:10 +0100
            Re: [patch] nvme-fabrics: correct some printk information Joe Perches <joe@perches.com> - 2016-12-10 23:30 +0100
        Re: [patch] nvme-fabrics: correct some printk information Joe Perches <joe@perches.com> - 2016-12-11 01:40 +0100
  Re: [patch] nvme-fabrics: correct some printk information James Smart <james.smart@broadcom.com> - 2016-12-20 01:50 +0100
    Re: [patch] nvme-fabrics: correct some printk information Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-20 10:20 +0100

csiph-web