Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1540181

Re: Should xhci_irq() call usb_hc_died()?

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Bjorn Helgaas <helgaas@kernel.org> writes:
> Hi Mathias,
>
> ehci_irq(), ohci_irq(), fotg210_irq(), and oxu210_hcd_irq() contain code
> equivalent to this:
>
>   status = ehci_readl(...);
>   if (status == ~(u32) 0) {
>     ...
>     usb_hc_died(hcd);
>     ...
>     return IRQ_HANDLED;
>   }
>
> xhci_irq() has a similar check, but does not call usb_hc_died():
>
>   status = readl(...);
>   if (status = 0xffffffff) {
>     ...
>     return IRQ_HANDLED;
>   }
>
> Should xhci_irq() also call usb_hc_died()?  Maybe there's some reason
> for it to be different than the others, but it wasn't obvious to this
> casual observer :)

you might just have fixed several bugs in dealing with a dead HC :-)

Can you provide a patch? (well, unless Mathias has a strong reason not
to call usb_hc_died(), of course).

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Should xhci_irq() call usb_hc_died()? Bjorn Helgaas <helgaas@kernel.org> - 2016-12-10 01:30 +0100
  Re: Should xhci_irq() call usb_hc_died()? Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-12-12 09:50 +0100
    Re: Should xhci_irq() call usb_hc_died()? Mathias Nyman <mathias.nyman@linux.intel.com> - 2016-12-12 11:50 +0100

csiph-web