Re: [PATCH v5 2/5] i2c: Add STM32F4 I2C driver

From	"M'boumba Cedric Madianga" <cedric.madianga@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 2/5] i2c: Add STM32F4 I2C driver
Date	2016-12-12 09:40 +0100
Message-ID	<sNujn-22B-7@gated-at.bofh.it> (permalink)
References	<sM2fv-3Ni-7@gated-at.bofh.it> <sM2fv-3Ni-13@gated-at.bofh.it> <sNkal-4fW-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Wolfram,

Thanks for your comments.
I will fix all of them + build errors reported by build-bot in the V6.

Best regards,

Cedric Madianga

2016-12-11 22:42 GMT+01:00 Wolfram Sang <wsa@the-dreams.de>:
> Hi,
>
>> +config I2C_STM32F4
>> +     tristate "STMicroelectronics STM32F4 I2C support"
>> +     depends on ARCH_STM32  || COMPILE_TEST
>
> Double space.
>
>> +#define STM32F4_I2C_MIN_FREQ         2
>> +#define STM32F4_I2C_MAX_FREQ         42
>
> Those two must be unsigned to fix the build error (e.g. 2U) reported by
> build-bot.
>
> Also, I get the following build warnings:
>
>   CC      drivers/i2c/busses/i2c-stm32f4.o
> drivers/i2c/busses/i2c-stm32f4.c: In function ‘stm32f4_i2c_handle_rx_addr’:
> drivers/i2c/busses/i2c-stm32f4.c:445:6: warning: variable ‘sr2’ set but not used [-Wunused-but-set-variable]
>   u32 sr2;
>       ^~~
> drivers/i2c/busses/i2c-stm32f4.c: In function ‘stm32f4_i2c_isr_event’:
> drivers/i2c/busses/i2c-stm32f4.c:496:41: warning: variable ‘sr2’ set but not used [-Wunused-but-set-variable]
>   u32 real_status, possible_status, ien, sr2;
>
> I assume those are reads to clear the register, so we really don't need
> to save the value in a variable.
>
> Rest is looking good.
>
> Thanks,
>
>    Wolfram
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/5] Add support for the STM32F4 I2C M'boumba Cedric Madianga <cedric.madianga@gmail.com> - 2016-12-08 09:30 +0100
  [PATCH v5 4/5] ARM: dts: Add I2C1 support for STM32429 eval board M'boumba Cedric Madianga <cedric.madianga@gmail.com> - 2016-12-08 09:30 +0100
    Re: [PATCH v5 4/5] ARM: dts: Add I2C1 support for STM32429 eval board Alexandre Torgue <alexandre.torgue@st.com> - 2016-12-08 09:40 +0100
      Re: [PATCH v5 4/5] ARM: dts: Add I2C1 support for STM32429 eval board "M'boumba Cedric Madianga" <cedric.madianga@gmail.com> - 2016-12-08 09:50 +0100
  [PATCH v5 1/5] dt-bindings: Document the STM32 I2C bindings M'boumba Cedric Madianga <cedric.madianga@gmail.com> - 2016-12-08 09:30 +0100
  [PATCH v5 3/5] ARM: dts: Add I2C1 support for STM32F429 SoC M'boumba Cedric Madianga <cedric.madianga@gmail.com> - 2016-12-08 09:30 +0100
  [PATCH v5 2/5] i2c: Add STM32F4 I2C driver M'boumba Cedric Madianga <cedric.madianga@gmail.com> - 2016-12-08 09:30 +0100
    Re: [PATCH v5 2/5] i2c: Add STM32F4 I2C driver kbuild test robot <lkp@intel.com> - 2016-12-08 13:20 +0100
    Re: [PATCH v5 2/5] i2c: Add STM32F4 I2C driver Wolfram Sang <wsa@the-dreams.de> - 2016-12-11 22:50 +0100
      Re: [PATCH v5 2/5] i2c: Add STM32F4 I2C driver "M'boumba Cedric Madianga" <cedric.madianga@gmail.com> - 2016-12-12 09:40 +0100

csiph-web