Re: [PATCH 2/2] kcov: make kcov work properly with KASLR enabled

From	Dmitry Vyukov <dvyukov@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] kcov: make kcov work properly with KASLR enabled
Date	2016-12-12 08:00 +0100
Message-ID	<sNsKB-11W-15@gated-at.bofh.it> (permalink)
References	<sN0EG-K2-5@gated-at.bofh.it> <sN0EG-K2-3@gated-at.bofh.it> <sN8LU-5UR-5@gated-at.bofh.it> <sNk0F-4cw-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Dec 11, 2016 at 10:37 PM, Alexander Popov <alex.popov@linux.com> wrote:
> On 11.12.2016 12:32, Dmitry Vyukov wrote:
>> On Sun, Dec 11, 2016 at 1:50 AM, Alexander Popov <alex.popov@linux.com> wrote:
>>> Subtract KASLR offset from the kernel addresses reported by kcov.
>>> Tested on x86_64 and AArch64 (Hikey LeMaker).
>>>
>>> Signed-off-by: Alexander Popov <alex.popov@linux.com>
>>> ---
>>>  kernel/kcov.c | 8 +++++++-
>>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> I think generally this is the right thing to do.
>>
>>  There are 2 pending patches for kcov by +Quentin (hopefully in mm):
>> "kcov: add AFL-style tracing"
>> "kcov: size of arena is now given in bytes"
>> https://groups.google.com/forum/#!topic/syzkaller/gcqbIhKjGcY
>> https://groups.google.com/d/msg/syzkaller/gcqbIhKjGcY/KQFryjBKCAAJ
>>
>> Your patch probably conflicts with them.
>> Should you base them on top of these patches, so that Andrew can merge
>> it without conflicts?
>
> Excuse me, I can't find these patches in:
> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git
> git://git.cmpxchg.org/linux-mmots.git
>
> Could you point at the tree which I can rebase onto?
> Should I cherry-pick Quentin's patches manually?


Quentin, do you know destiny of your patches? They does not seem to be
in mm tree.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] kcov: make kcov work properly with KASLR enabled Alexander Popov <alex.popov@linux.com> - 2016-12-11 02:00 +0100
  Re: [PATCH 2/2] kcov: make kcov work properly with KASLR enabled Dmitry Vyukov <dvyukov@google.com> - 2016-12-11 10:40 +0100
    Re: [PATCH 2/2] kcov: make kcov work properly with KASLR enabled Alexander Popov <alex.popov@linux.com> - 2016-12-11 22:40 +0100
      Re: [PATCH 2/2] kcov: make kcov work properly with KASLR enabled Dmitry Vyukov <dvyukov@google.com> - 2016-12-12 08:00 +0100

csiph-web