Re: [PATCH v2 3/4] printk/btrfs: Handle more message headers

From	David Sterba <dsterba@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/4] printk/btrfs: Handle more message headers
Date	2016-12-13 15:30 +0100
Message-ID	<sNWfE-2go-43@gated-at.bofh.it> (permalink)
References	<sBAud-7n4-3@gated-at.bofh.it> <sBAud-7n4-5@gated-at.bofh.it> <sNRzj-7SM-5@gated-at.bofh.it> <sNVMC-1R9-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Dec 13, 2016 at 02:52:47PM +0100, Petr Mladek wrote:
> Here is the proposed fix for the warning:
> 
> 
> From 5b5a8f7ff4f2d5c33316e600a29d45314ac47a16 Mon Sep 17 00:00:00 2001
> From: Petr Mladek <pmladek@suse.com>
> Date: Tue, 13 Dec 2016 13:12:56 +0100
> Subject: [PATCH] btrfs: Better handle btrfs_printk() defaults
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> The commit 262c5e86fec7cfd ("printk/btrfs: handle more message headers")
> triggers:
> 
>     warning: ‘ratelimit’ may be used uninitialized in this function
> 
> with gcc (4.1.2) and probably many other versions. The code actually
> is correct but a bit twisted. Let's make it more straightforward
> and set the default values at the beginning.
> 
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Petr Mladek <pmladek@suse.com>

Acked-by: David Sterba <dsterba@suse.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 3/4] printk/btrfs: Handle more message headers Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-13 10:30 +0100
  Re: [PATCH v2 3/4] printk/btrfs: Handle more message headers Petr Mladek <pmladek@suse.com> - 2016-12-13 15:00 +0100
    Re: [PATCH v2 3/4] printk/btrfs: Handle more message headers Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-13 15:10 +0100
    Re: [PATCH v2 3/4] printk/btrfs: Handle more message headers David Sterba <dsterba@suse.cz> - 2016-12-13 15:30 +0100

csiph-web