Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1541017

Re: [PATCH] cifs: Fix smbencrypt() to stop pointing a scatterlist at the stack

From Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups linux.kernel
Subject Re: [PATCH] cifs: Fix smbencrypt() to stop pointing a scatterlist at the stack
Date 2016-12-13 12:50 +0100
Message-ID <sNTKN-FZ-15@gated-at.bofh.it> (permalink)
References <sNFRv-yr-13@gated-at.bofh.it> <sNFRw-yr-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hello!

On 12/12/2016 11:54 PM, Andy Lutomirski wrote:

> smbencrypt() points a scatterlist to the stack, which is breaks if

    s/is//.

> CONFIG_VMAP_STACK=y.
>
> Fix it by switching to crypto_cipher_encrypt_one().  The new code
> should be considerably faster as an added benefit.
>
> This code is nearly identical to some code that Eric Biggers
> suggested.
>
> Cc: stable@vger.kernel.org # 4.9 only
> Reported-by: Eric Biggers <ebiggers3@gmail.com>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
[...]

MBR, Sergei

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] cifs: Fix smbencrypt() to stop pointing a scatterlist at the stack Andy Lutomirski <luto@kernel.org> - 2016-12-12 22:00 +0100
  Re: [PATCH] cifs: Fix smbencrypt() to stop pointing a scatterlist at  the stack Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-12-13 12:50 +0100
  Re: [PATCH] cifs: Fix smbencrypt() to stop pointing a scatterlist  at the stack Jeff Layton <jlayton@redhat.com> - 2016-12-13 14:10 +0100
    Re: [PATCH] cifs: Fix smbencrypt() to stop pointing a scatterlist at  the stack Steve French <smfrench@gmail.com> - 2016-12-14 09:20 +0100

csiph-web