Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1540857
| From | Cong Wang <xiyou.wangcong@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: CVE-2016-7097 causes acl leak |
| Date | 2016-12-13 07:30 +0100 |
| Message-ID | <sNOL7-6aF-7@gated-at.bofh.it> (permalink) |
| References | <sL55L-7o6-23@gated-at.bofh.it> <sNmOS-5RV-7@gated-at.bofh.it> <sNJ8K-2DO-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Dec 12, 2016 at 4:26 PM, Mark Salyzyn <salyzyn@android.com> wrote:
>
> The leaks were introduced in 9p, gfs2, jfs and xfs drivers only.
Only the 9p case is obvious to me:
diff --git a/fs/9p/acl.c b/fs/9p/acl.c
index b3c2cc7..082d227 100644
--- a/fs/9p/acl.c
+++ b/fs/9p/acl.c
@@ -277,6 +277,7 @@ static int v9fs_xattr_set_acl(const struct
xattr_handler *handler,
case ACL_TYPE_ACCESS:
if (acl) {
struct iattr iattr;
+ struct posix_acl *old_acl = acl;
retval = posix_acl_update_mode(inode,
&iattr.ia_mode, &acl);
if (retval)
@@ -287,6 +288,7 @@ static int v9fs_xattr_set_acl(const struct
xattr_handler *handler,
* by the mode bits. So don't
* update ACL.
*/
+ posix_acl_release(old_acl);
value = NULL;
size = 0;
}
The rest are anti-pattern (modifying parameters on stack via address)
but look correct.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: CVE-2016-7097 causes acl leak Cong Wang <xiyou.wangcong@gmail.com> - 2016-12-12 01:40 +0100
Re: CVE-2016-7097 causes acl leak Jan Kara <jack@suse.cz> - 2016-12-12 11:50 +0100
Re: CVE-2016-7097 causes acl leak Cong Wang <xiyou.wangcong@gmail.com> - 2016-12-12 22:20 +0100
Re: CVE-2016-7097 causes acl leak Mark Salyzyn <salyzyn@android.com> - 2016-12-13 01:30 +0100
Re: CVE-2016-7097 causes acl leak Cong Wang <xiyou.wangcong@gmail.com> - 2016-12-13 07:30 +0100
Re: CVE-2016-7097 causes acl leak Jan Kara <jack@suse.cz> - 2016-12-13 12:30 +0100
Re: CVE-2016-7097 causes acl leak Cong Wang <xiyou.wangcong@gmail.com> - 2016-12-14 01:00 +0100
Re: CVE-2016-7097 causes acl leak Mark Salyzyn <salyzyn@android.com> - 2016-12-13 17:00 +0100
Re: CVE-2016-7097 causes acl leak Jan Kara <jack@suse.cz> - 2016-12-13 17:10 +0100
Re: CVE-2016-7097 causes acl leak Mark Salyzyn <salyzyn@android.com> - 2016-12-14 00:50 +0100
Re: CVE-2016-7097 causes acl leak Greg KH <gregkh@linuxfoundation.org> - 2016-12-14 01:10 +0100
Re: CVE-2016-7097 causes acl leak Mark Salyzyn <salyzyn@android.com> - 2016-12-14 21:30 +0100
Re: CVE-2016-7097 causes acl leak Greg KH <gregkh@linuxfoundation.org> - 2016-12-15 00:40 +0100
Re: CVE-2016-7097 causes acl leak Mark Salyzyn <salyzyn@android.com> - 2016-12-15 16:30 +0100
Re: CVE-2016-7097 causes acl leak Jan Kara <jack@suse.cz> - 2016-12-15 17:40 +0100
Re: CVE-2016-7097 causes acl leak Jan Kara <jack@suse.cz> - 2016-12-13 12:20 +0100
csiph-web