Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1540823

Re: Remaining crypto API regressions with CONFIG_VMAP_STACK

Show all headers | View raw

On Mon, Dec 12, 2016 at 12:45:18PM -0600, Gary R Hook wrote:
> On 12/12/2016 12:34 PM, Andy Lutomirski wrote:
> 
> <...snip...>
> 
> >
> >I have a patch to make these depend on !VMAP_STACK.
> >
> >>        drivers/crypto/ccp/ccp-crypto-aes-cmac.c:105,119,142
> >>        drivers/crypto/ccp/ccp-crypto-sha.c:95,109,124
> >>        drivers/crypto/ccp/ccp-crypto-aes-xts.c:162
> >>        drivers/crypto/ccp/ccp-crypto-aes.c:94
> >
> >According to Herbert, these are fine.  I'm personally less convinced
> >since I'm very confused as to what "async" means in the crypto code,
> >but I'm going to leave these alone.
> 
> I went back through the code, and AFAICT every argument to sg_init_one() in
> the above-cited files is a buffer that is part of the request context. Which
> is allocated by the crypto framework, and therefore will never be on the
> stack.
> Right?

Right.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: Remaining crypto API regressions with CONFIG_VMAP_STACK Andy Lutomirski <luto@amacapital.net> - 2016-12-12 19:40 +0100
  Re: Remaining crypto API regressions with CONFIG_VMAP_STACK Herbert Xu <herbert@gondor.apana.org.au> - 2016-12-13 04:40 +0100
    Re: Remaining crypto API regressions with CONFIG_VMAP_STACK Andy Lutomirski <luto@amacapital.net> - 2016-12-13 18:10 +0100
      Re: Remaining crypto API regressions with CONFIG_VMAP_STACK Herbert Xu <herbert@gondor.apana.org.au> - 2016-12-14 06:00 +0100
  Re: Remaining crypto API regressions with CONFIG_VMAP_STACK Herbert Xu <herbert@gondor.apana.org.au> - 2016-12-13 04:50 +0100

csiph-web