[PATCH] Input: ar1021-i2c - fix too long name in driver's device table

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] Input: ar1021-i2c - fix too long name in driver's device table
Date	2016-12-13 01:00 +0100
Message-ID	<sNIFN-2fm-27@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The name field in structure i2c_device_id is 20 characters, and we
expect it to be NULL-terminated, however we are trying to stuff it with
21 bytes and thus NULL-terminator is lost. This causes issues when one
creates device with name "MICROCHIP_AR1021_I2C" as i2c core cuts off the
last "C", and automatic module loading by alias does not work as result.

The -I2C suffix in the device name is superfluous, we know what bus we
are dealing with, so let's drop it.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=116211
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/touchscreen/ar1021_i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c
index 71b5a63..89f9587 100644
--- a/drivers/input/touchscreen/ar1021_i2c.c
+++ b/drivers/input/touchscreen/ar1021_i2c.c
@@ -152,7 +152,7 @@ static int __maybe_unused ar1021_i2c_resume(struct device *dev)
 static SIMPLE_DEV_PM_OPS(ar1021_i2c_pm, ar1021_i2c_suspend, ar1021_i2c_resume);
 
 static const struct i2c_device_id ar1021_i2c_id[] = {
-	{ "MICROCHIP_AR1021_I2C", 0 },
+	{ "MICROCHIP_AR1021", 0 },
 	{ },
 };
 MODULE_DEVICE_TABLE(i2c, ar1021_i2c_id);
-- 
2.8.0.rc3.226.g39d4020


-- 
Dmitry

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] Input: ar1021-i2c - fix too long name in driver's device  table Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-12-13 01:00 +0100
  Re: [PATCH] Input: ar1021-i2c - fix too long name in driver's device  table Wolfram Sang <wsa@the-dreams.de> - 2016-12-13 07:00 +0100
  Re: [PATCH] Input: ar1021-i2c - fix too long name in driver's device table Christian Gmeiner <christian.gmeiner@gmail.com> - 2016-12-13 08:50 +0100
  Re: [PATCH] Input: ar1021-i2c - fix too long name in driver's  device table Jean Delvare <jdelvare@suse.de> - 2016-12-13 15:10 +0100

csiph-web