Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1540557
| From | Michael Turquette <mturquette@baylibre.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] clk/axs10x: Clear init field in driver probe |
| Date | 2016-12-12 20:10 +0100 |
| Message-ID | <sNE93-8b3-29@gated-at.bofh.it> (permalink) |
| References | <sNwEy-3Ar-31@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Quoting Jose Abreu (2016-12-12 03:08:55) > Init field must be cleared in driver probe as this structure is not dinamically allocated. If not, wrong flags can be passed to core. > > Signed-off-by: Jose Abreu <joabreu@synopsys.com> Applied to clk-next. You can find this patch merged after v4.10-rc1 is released in a couple of weeks. Regards, Mike > Cc: Carlos Palminha <palminha@synopsys.com> > Cc: Stephen Boyd <sboyd@codeaurora.org> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: linux-clk@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/clk/axs10x/i2s_pll_clock.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/axs10x/i2s_pll_clock.c b/drivers/clk/axs10x/i2s_pll_clock.c > index 411310d..02d3bcd 100644 > --- a/drivers/clk/axs10x/i2s_pll_clock.c > +++ b/drivers/clk/axs10x/i2s_pll_clock.c > @@ -182,6 +182,7 @@ static int i2s_pll_clk_probe(struct platform_device *pdev) > if (IS_ERR(pll_clk->base)) > return PTR_ERR(pll_clk->base); > > + memset(&init, 0, sizeof(init)); > clk_name = node->name; > init.name = clk_name; > init.ops = &i2s_pll_ops; > -- > 1.9.1 > >
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] clk/axs10x: Clear init field in driver probe Jose Abreu <Jose.Abreu@synopsys.com> - 2016-12-12 12:10 +0100 Re: [PATCH] clk/axs10x: Clear init field in driver probe Michael Turquette <mturquette@baylibre.com> - 2016-12-12 20:10 +0100
csiph-web