Re: [PATCH] Revert "tty: serial: 8250: add CON_CONSDEV to flags"

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Revert "tty: serial: 8250: add CON_CONSDEV to flags"
Date	2016-12-11 08:20 +0100
Message-ID	<sN6Ap-4DD-5@gated-at.bofh.it> (permalink)
References	<sN1Kq-1A4-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Dec 11, 2016 at 10:05:49AM +0800, Herbert Xu wrote:
> This commit needs to be reverted because it prevents people from
> using the serial console as a secondary console with input being
> directed to tty0.
> 
> IOW, if you boot with console=ttyS0 console=tty0 then all kernels
> prior to this commit will produce output on both ttyS0 and tty0
> but input will only be taken from tty0.  With this patch the serial
> console will always be the primary console instead of tty0,
> potentially preventing people from getting into their machines in
> emergency situations.
> 
> Fixes: d03516df8375 ("tty: serial: 8250: add CON_CONSDEV to flags")
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> 
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index 240a361..e8819aa 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -675,7 +675,7 @@ static int univ8250_console_match(struct console *co, char *name, int idx,
>  	.device		= uart_console_device,
>  	.setup		= univ8250_console_setup,
>  	.match		= univ8250_console_match,
> -	.flags		= CON_PRINTBUFFER | CON_ANYTIME | CON_CONSDEV,
> +	.flags		= CON_PRINTBUFFER | CON_ANYTIME,
>  	.index		= -1,
>  	.data		= &serial8250_reg,
>  };

Ok, this is the second time this has been reported.  Matthew seems to be
ignoring my email about this, so I guess I'll just revert the patch, as
it's obviously causing problems...

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Revert "tty: serial: 8250: add CON_CONSDEV to flags" Herbert Xu <herbert@gondor.apana.org.au> - 2016-12-11 03:10 +0100
  Re: [PATCH] Revert "tty: serial: 8250: add CON_CONSDEV to flags" Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-11 08:20 +0100

csiph-web