Re: [PATCH 3/6] net: ethernet: ti: cpts: add support of cpts HW_TS_PUSH

From	Richard Cochran <richardcochran@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/6] net: ethernet: ti: cpts: add support of cpts HW_TS_PUSH
Date	2016-12-09 10:00 +0100
Message-ID	<sMpc6-16k-9@gated-at.bofh.it> (permalink)
References	<sIDdD-75-21@gated-at.bofh.it> <sIDdD-75-23@gated-at.bofh.it> <sKrUJ-7TT-3@gated-at.bofh.it> <sMceR-1um-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Dec 08, 2016 at 01:04:11PM -0600, Grygorii Strashko wrote:
> huh. Seems this is not really good idea, because MISC Irq will be 
> triggered for *any* CPTS event and there is no way to enable it just for
> HW_TS_PUSH.

So what?  That is not a problem.

> So, this doesn't work will with current code for RX/TX timestamping
> (which uses polling mode).

Why doesn't it work?

> + runtime overhead in net RX/TX caused by 
> triggering more interrupts. 

This is not relevant.  Without HW_TS_PUSH, there is no need for
enabling the interrupt simply because we don't need it.  Now, with
HW_TS_PUSH, we do need it.

> May be, overflow check/polling timeout can be made configurable (module parameter). 

No, it should just work without any user space fiddling.

I getting a bit tired of your half-baked implementations of the
ancillary clock functions.  Either do it right, or just leave it
unsupported.

Thanks,
Richard

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/6] net: ethernet: ti: cpts: add support of cpts HW_TS_PUSH Grygorii Strashko <grygorii.strashko@ti.com> - 2016-11-29 00:10 +0100
  Re: [PATCH 3/6] net: ethernet: ti: cpts: add support of cpts  HW_TS_PUSH Richard Cochran <richardcochran@gmail.com> - 2016-11-30 11:20 +0100
  Re: [PATCH 3/6] net: ethernet: ti: cpts: add support of cpts  HW_TS_PUSH Jan Lübbe <jlu@pengutronix.de> - 2016-11-30 12:10 +0100
    Re: [PATCH 3/6] net: ethernet: ti: cpts: add support of cpts  HW_TS_PUSH Grygorii Strashko <grygorii.strashko@ti.com> - 2016-11-30 21:20 +0100
  Re: [PATCH 3/6] net: ethernet: ti: cpts: add support of cpts  HW_TS_PUSH Richard Cochran <richardcochran@gmail.com> - 2016-12-04 00:30 +0100
    Re: [PATCH 3/6] net: ethernet: ti: cpts: add support of cpts  HW_TS_PUSH Grygorii Strashko <grygorii.strashko@ti.com> - 2016-12-08 20:10 +0100
      Re: [PATCH 3/6] net: ethernet: ti: cpts: add support of cpts  HW_TS_PUSH Richard Cochran <richardcochran@gmail.com> - 2016-12-09 10:00 +0100

csiph-web