Re: [PATCH 1/7] dell-led: remove GUID check from dell_micmute_led_set()

From	Pali Rohár <pali.rohar@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/7] dell-led: remove GUID check from dell_micmute_led_set()
Date	2016-12-09 10:30 +0100
Message-ID	<sMpFd-1vm-13@gated-at.bofh.it> (permalink)
References	<sM69r-68W-7@gated-at.bofh.it> <sM69s-68W-49@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thursday 08 December 2016 13:36:12 Michał Kępień wrote:
> As dell_micmute_led_set() no longer uses the dell_wmi_perform_query()
> method, which was removed in 0c41a08 ("dell-led: use
> dell_smbios_send_request() for performing SMBIOS calls"), the
> DELL_APP_GUID check is redundant and thus can be safely removed.
> 
> Signed-off-by: Michał Kępień <kernel@kempniu.pl>
> ---
>  drivers/leds/dell-led.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/leds/dell-led.c b/drivers/leds/dell-led.c
> index b3d6e9c..e8e8f67 100644
> --- a/drivers/leds/dell-led.c
> +++ b/drivers/leds/dell-led.c
> @@ -51,9 +51,6 @@ static int dell_micmute_led_set(int state)
>  	struct calling_interface_buffer *buffer;
>  	struct calling_interface_token *token;
>  
> -	if (!wmi_has_guid(DELL_APP_GUID))
> -		return -ENODEV;
> -
>  	if (state == 0)
>  		token = dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE);
>  	else if (state == 1)

Reviewed-by: Pali Rohár <pali.rohar@gmail.com>

Anyway, you can remove DELL_APP_GUID from other places too...

-- 
Pali Rohár
pali.rohar@gmail.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/7] dell-led: remove GUID check from dell_micmute_led_set() Michał Kępień <kernel@kempniu.pl> - 2016-12-08 13:40 +0100
  Re: [PATCH 1/7] dell-led: remove GUID check from  dell_micmute_led_set() Pali Rohár <pali.rohar@gmail.com> - 2016-12-09 10:30 +0100

csiph-web