Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1539145

Re: [PATCH] Staging: ks7010: ks7010_sdio.h: Fixed coding style errors

Show all headers | View raw

On Fri, Dec 09, 2016 at 12:29:21PM +0000, Manoj Sawai wrote:
> Errors - Complex macro not a parentheses and trailing whitespace
> Also fixed other small checkpatch warnings and checks.

If you ever say "also" in a changelog, that's a huge hint that the patch
needs to be broken up into multiple patches.  That is the case here,
please only do one type of coding style fix at a time.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: ks7010: ks7010_sdio.h: Fixed coding style errors Manoj Sawai <mas@iitkgp.ac.in> - 2016-12-09 08:00 +0100
  Re: [PATCH] Staging: ks7010: ks7010_sdio.h: Fixed coding style errors Greg KH <gregkh@linuxfoundation.org> - 2016-12-09 08:10 +0100

csiph-web