RE: [PATCH] ACPI / OSL: Fix a regression by returning table size via acpi_get_table_with_size()

From	"Zheng, Lv" <lv.zheng@intel.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] ACPI / OSL: Fix a regression by returning table size via acpi_get_table_with_size()
Date	2016-12-09 07:10 +0100
Message-ID	<sMmxA-8aC-5@gated-at.bofh.it> (permalink)
References	<sJ7v3-34Y-3@gated-at.bofh.it> <sMj6G-5Kl-3@gated-at.bofh.it> <sMkm6-6zB-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi, Rafael

> From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of Rafael J. Wysocki
> Subject: Re: [PATCH] ACPI / OSL: Fix a regression by returning table size via
> acpi_get_table_with_size()
> 
> On Fri, Dec 9, 2016 at 3:21 AM, Lv Zheng <lv.zheng@intel.com> wrote:
> > The returned size is still used by the drivers.
> >
> > Reported-by: Dan Williams <dan.j.williams@intel.com>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Signed-off-by: Lv Zheng <lv.zheng@intel.com>
> > ---
> >  drivers/acpi/osl.c |    8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> > index 5bef0f65..adf1ec4 100644
> > --- a/drivers/acpi/osl.c
> > +++ b/drivers/acpi/osl.c
> > @@ -445,8 +445,12 @@ void __ref acpi_os_unmap_memory(void *virt, acpi_size size)
> >
> >         status = acpi_get_table(signature, instance, out_table);
> >         if (ACPI_SUCCESS(status)) {
> > -               /* No longer used by early_acpi_os_unmap_memory() */
> > -               *tbl_size = 0;
> > +               /*
> > +                * No longer used by early_acpi_os_unmap_memory(), but still
> > +                * used by the ACPI table drivers.
> > +                */
> > +               if (*out_table)
> > +                       *tbl_size = (*out_table)->length;
> >         }
> >
> >         return (status);
> > --
> 
> The changelog doesn't explain anything.  Please say (a) what the
> problem is and (b) how it is being addressed by your patch.

OK, I'll also add fixes tag to it.

Thanks
Lv

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 00/11] ACPICA: 20161117 Release Lv Zheng <lv.zheng@intel.com> - 2016-11-30 08:30 +0100
  [PATCH 08/11] ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel Lv Zheng <lv.zheng@intel.com> - 2016-11-30 08:30 +0100
    Re: [PATCH 08/11] ACPICA: Tables: Back port acpi_get_table_with_size()  and early_acpi_os_unmap_memory() from Linux kernel Dan Williams <dan.j.williams@intel.com> - 2016-12-08 02:20 +0100
      Re: [PATCH 08/11] ACPICA: Tables: Back port acpi_get_table_with_size()  and early_acpi_os_unmap_memory() from Linux kernel "Rafael J. Wysocki" <rafael@kernel.org> - 2016-12-08 14:20 +0100
        Re: [PATCH 08/11] ACPICA: Tables: Back port acpi_get_table_with_size()  and early_acpi_os_unmap_memory() from Linux kernel Dan Williams <dan.j.williams@intel.com> - 2016-12-08 20:10 +0100
          RE: [PATCH 08/11] ACPICA: Tables: Back port  acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Zheng, Lv" <lv.zheng@intel.com> - 2016-12-09 03:00 +0100
            Re: [PATCH 08/11] ACPICA: Tables: Back port acpi_get_table_with_size()  and early_acpi_os_unmap_memory() from Linux kernel "Rafael J. Wysocki" <rafael@kernel.org> - 2016-12-09 03:10 +0100
              RE: [PATCH 08/11] ACPICA: Tables: Back port  acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Zheng, Lv" <lv.zheng@intel.com> - 2016-12-09 03:30 +0100
            Re: [PATCH 08/11] ACPICA: Tables: Back port acpi_get_table_with_size()  and early_acpi_os_unmap_memory() from Linux kernel Dan Williams <dan.j.williams@intel.com> - 2016-12-09 03:10 +0100
              RE: [PATCH 08/11] ACPICA: Tables: Back port  acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Zheng, Lv" <lv.zheng@intel.com> - 2016-12-09 03:20 +0100
              RE: [PATCH 08/11] ACPICA: Tables: Back port  acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Zheng, Lv" <lv.zheng@intel.com> - 2016-12-09 03:30 +0100
      Re: [PATCH 08/11] ACPICA: Tables: Back port acpi_get_table_with_size()  and early_acpi_os_unmap_memory() from Linux kernel Dan Williams <dan.j.williams@intel.com> - 2016-12-09 03:00 +0100
      RE: [PATCH 08/11] ACPICA: Tables: Back port  acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel "Zheng, Lv" <lv.zheng@intel.com> - 2016-12-09 03:00 +0100
  [PATCH] ACPI / OSL: Fix a regression by returning table size via acpi_get_table_with_size() Lv Zheng <lv.zheng@intel.com> - 2016-12-09 03:30 +0100
    Re: [PATCH] ACPI / OSL: Fix a regression by returning table size via acpi_get_table_with_size() "Rafael J. Wysocki" <rafael@kernel.org> - 2016-12-09 04:50 +0100
      RE: [PATCH] ACPI / OSL: Fix a regression by returning table size  via acpi_get_table_with_size() "Zheng, Lv" <lv.zheng@intel.com> - 2016-12-09 07:10 +0100

csiph-web