Re: [PATCH] ppdev: don't print a free'd string

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ppdev: don't print a free'd string
Date	2016-12-08 23:20 +0100
Message-ID	<sMfcJ-3mi-3@gated-at.bofh.it> (permalink)
References	<sJYSJ-6cO-11@gated-at.bofh.it> <sLlDA-XN-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tuesday 06 December 2016 10:51 AM, Greg Kroah-Hartman wrote:
> On Fri, Dec 02, 2016 at 04:23:55PM +0000, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> A previous fix of a memory leak now prints the string 'name'
>> that was previously free'd.  Fix this by free'ing the string
>> at the end of the function and adding an error exit path for
>> the error conditions.
>>
>> CoverityScan CID#1384523 ("Use after free")
>>
>> Fixes: 2bd362d5f45c1 ("ppdev: fix memory leak")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>>   drivers/char/ppdev.c | 13 ++++++++-----
>>   1 file changed, 8 insertions(+), 5 deletions(-)
>
> Sudip, any thoughts?
>

Hi Greg,

Sorry for the late reply. It looks good.

Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>


Regards
Sudip

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ppdev: don't print a free'd string Colin King <colin.king@canonical.com> - 2016-12-02 17:30 +0100
  Re: [PATCH] ppdev: don't print a free'd string Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-06 12:00 +0100
    Re: [PATCH] ppdev: don't print a free'd string Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-12-08 23:20 +0100

csiph-web