Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1538942
| From | Marek Vasut <marex@denx.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v11 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD |
| Date | 2016-12-09 00:10 +0100 |
| Message-ID | <sMfZ7-3TC-1@gated-at.bofh.it> (permalink) |
| References | <sMfmq-3pr-9@gated-at.bofh.it> <sMfmq-3pr-31@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 12/08/2016 11:27 PM, Ksenija Stanojevic wrote: > Add core files for low resolution analog-to-digital converter (mxs-lradc) > MFD driver. > > Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com> Just a nit below. > +++ b/include/linux/mfd/mxs-lradc.h > @@ -0,0 +1,187 @@ > +/* [...] > +#define LRADC_CTRL1_MX28_LRADC_IRQ_EN_MASK (0x1fff << 16) > +#define LRADC_CTRL1_MX23_LRADC_IRQ_EN_MASK (0x01ff << 16) > +#define LRADC_CTRL1_LRADC_IRQ_EN_OFFSET 16 > +#define LRADC_CTRL1_TOUCH_DETECT_IRQ BIT(8) > +#define LRADC_CTRL1_LRADC_IRQ(n) (1 << (n)) This would turn into BIT(n) , no ? > +#define LRADC_CTRL1_MX28_LRADC_IRQ_MASK 0x1fff > +#define LRADC_CTRL1_MX23_LRADC_IRQ_MASK 0x01ff > +#define LRADC_CTRL1_LRADC_IRQ_OFFSET 0 [...] -- Best regards, Marek Vasut
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v11 0/5] mxs-lradc: Split driver into MFD Ksenija Stanojevic <ksenija.stanojevic@gmail.com> - 2016-12-08 23:30 +0100
[PATCH v11 3/5] input: touchscreen: mxs-lradc: Add support for touchscreen Ksenija Stanojevic <ksenija.stanojevic@gmail.com> - 2016-12-08 23:30 +0100
[PATCH v11 5/5] mfd: Move binding document Ksenija Stanojevic <ksenija.stanojevic@gmail.com> - 2016-12-08 23:30 +0100
[PATCH v11 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD Ksenija Stanojevic <ksenija.stanojevic@gmail.com> - 2016-12-08 23:30 +0100
Re: [PATCH v11 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD Marek Vasut <marex@denx.de> - 2016-12-09 00:10 +0100
Re: [PATCH v11 0/5] mxs-lradc: Split driver into MFD Marek Vasut <marex@denx.de> - 2016-12-09 00:10 +0100
csiph-web