Re: [PATCH v2 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

From	Hari Bathini <hbathini@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info
Date	2016-12-08 19:50 +0100
Message-ID	<sMbVv-188-23@gated-at.bofh.it> (permalink)
References	<sH3vA-43h-11@gated-at.bofh.it> <sH3vA-43h-29@gated-at.bofh.it> <sH3YB-4sR-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Peter,

Sorry for taking so long to respond...

On Thursday 24 November 2016 08:40 PM, Peter Zijlstra wrote:
> On Thu, Nov 24, 2016 at 08:14:29PM +0530, Hari Bathini wrote:
>> @@ -862,6 +875,19 @@ enum perf_event_type {
>>   	 */
>>   	PERF_RECORD_SWITCH_CPU_WIDE		= 15,
>>   
>> +	/*
>> +	 * struct {
>> +	 *	struct perf_event_header	header;
>> +	 *
>> +	 *	u32				pid, tid;
>> +	 *	u64				time;
> pid,tid and time are already present in sample_id. Many of the 'legacy'
> record have redundant information since we added sample_id, but most of
> the new ones haven't and rely on sample_all being set.

I tried using pid/tid from sample data, but realized that pid/tid in 
event_id
could be different from the one in sample data, at least for fork/namespaces
events, since __perf_event_header__init_id( ) that updates the sample data
is getting the pid/tid of current task.

I am not sure if it is advisable to change __perf_event_header__init_id( 
) for this..?

Thanks
Hari

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/3] perf: add PERF_RECORD_NAMESPACES to include  namespaces related info Hari Bathini <hbathini@linux.vnet.ibm.com> - 2016-12-08 19:50 +0100
  Re: [PATCH v2 1/3] perf: add PERF_RECORD_NAMESPACES to include  namespaces related info Hari Bathini <hbathini@linux.vnet.ibm.com> - 2016-12-09 11:20 +0100
  Re: [PATCH v2 1/3] perf: add PERF_RECORD_NAMESPACES to include  namespaces related info Peter Zijlstra <peterz@infradead.org> - 2016-12-09 15:10 +0100

csiph-web