Re: [PATCH] memremap: Remove unused align_* variables

From	Dan Williams <dan.j.williams@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] memremap: Remove unused align_* variables
Date	2016-12-08 18:20 +0100
Message-ID	<sMawp-pF-11@gated-at.bofh.it> (permalink)
References	<sM1CN-3fJ-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Dec 7, 2016 at 11:42 PM, Kirtika Ruchandani
<kirtika@chromium.org> wrote:
> Commit eb7d78c9e7f6 introduced align_start, align_size and align_end
> variables in pgmap_radix_release() but did not use them.
> Compiling with W=1 gives the following harmless warning, fix it to
> reduce the noise with W=1 in the kernel.
>
> kernel/memremap.c: In function ‘pgmap_radix_release’:
> kernel/memremap.c:199:48: warning: variable ‘align_end’ set but not used [-Wunused-but-set-variable]
>
> The call to resource_size has no side-effects and is safe to remove.
>
> Fixes: eb7d78c9e7f6 ("devm_memremap_pages: fix vmem_altmap lifetime + alignment handling")
> Cc: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Kirtika Ruchandani <kirtika@chromium.org>

Thanks for the fix, however I'm already addressing this as a side effect of:

    https://lkml.org/lkml/2016/12/1/726

I'm in the process of posting v2 of that patch.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] memremap: Remove unused align_* variables Kirtika Ruchandani <kirtika@chromium.org> - 2016-12-08 08:50 +0100
  Re: [PATCH] memremap: Remove unused align_* variables Dan Williams <dan.j.williams@intel.com> - 2016-12-08 18:20 +0100

csiph-web